Skip to content

Remove serde_camel_case and serde_kebab_case features#84

Merged
alice-i-cecile merged 1 commit intoDioxusLabs:mainfrom
alice-i-cecile:serde-rename-all
Jun 8, 2022
Merged

Remove serde_camel_case and serde_kebab_case features#84
alice-i-cecile merged 1 commit intoDioxusLabs:mainfrom
alice-i-cecile:serde-rename-all

Conversation

@alice-i-cecile
Copy link
Collaborator

Objective

  • these features are not correctly additive: enabling both features at once will break compilation
  • Rust analyzer is correctly complaining about duplicate attributes
  • these features are poorly motivated
  • presumably this is for cross-language serialization?
  • renaming like this is easily handled by external batch processing if needed

Migration Guide

If you were using these features, rename your generated serialization files manually (and get in touch to explain why you cared).

@alice-i-cecile alice-i-cecile added the code quality Make the code cleaner or prettier. label Jun 8, 2022
@alice-i-cecile alice-i-cecile enabled auto-merge (squash) June 8, 2022 16:58
@alice-i-cecile alice-i-cecile merged commit 5dde45d into DioxusLabs:main Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality Make the code cleaner or prettier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant