Skip to content

Prepare for release of new crate#53

Merged
alice-i-cecile merged 20 commits intoDioxusLabs:mainfrom
alice-i-cecile:remove-cruft
May 23, 2022
Merged

Prepare for release of new crate#53
alice-i-cecile merged 20 commits intoDioxusLabs:mainfrom
alice-i-cecile:remove-cruft

Conversation

@alice-i-cecile
Copy link
Copy Markdown
Collaborator

@alice-i-cecile alice-i-cecile commented May 20, 2022 •
edited
Loading

Objective

Context

Using the current leader in #42. If something else wins, we can do a simple find-and-replace.

For reviewers: review this on a commit-by-commit basis. 32bbc33 is a massive but trivial find-and-replace on the generated tests.

@alice-i-cecile alice-i-cecile added documentation Improvements or additions to documentation kotlin meta About the project itself code quality Make the code cleaner or prettier. labels May 20, 2022
@alice-i-cecile alice-i-cecile added this to the Release new crate milestone May 20, 2022
TimJentzsch
TimJentzsch reviewed May 20, 2022
View reviewed changes
@alice-i-cecile @TimJentzsch
Link to Discussions
9ad631f 
Co-authored-by: TimJentzsch <tim-jentzsch@gmx.de>
@alice-i-cecile
Copy link
Copy Markdown
Collaborator Author

alice-i-cecile commented May 20, 2022

@mockersf, any ideas on what's going on with CI here?

@alice-i-cecile @TimJentzsch
Revise wording in Cargo.toml description
8e419c2 
Co-authored-by: TimJentzsch <tim-jentzsch@gmx.de>
alice-i-cecile
alice-i-cecile commented May 20, 2022
View reviewed changes
@TimJentzsch
Copy link
Copy Markdown
Collaborator

TimJentzsch commented May 20, 2022

@mockersf, any ideas on what's going on with CI here?

To me it looks like it's trying to load something in stretch2, but can't find it due to the crate rename in Cargo.toml? Not entirely sure though.

@alice-i-cecile
Copy link
Copy Markdown
Collaborator Author

alice-i-cecile commented May 20, 2022

Yeah, it feels like it might be caching something?

@mockersf
Copy link
Copy Markdown
Contributor

mockersf commented May 20, 2022

you deleted the folder scripts/gentest, but it's still present in the workspace definition

@alice-i-cecile alice-i-cecile added breaking-change A change that breaks our public interface blocked Cannot be advanced until something else changes labels May 20, 2022
@TimJentzsch
Copy link
Copy Markdown
Collaborator

TimJentzsch commented May 21, 2022

you deleted the folder scripts/gentest, but it's still present in the workspace definition

I wonder, what exactly is the difference between scripts/gentest and tests/generated? Does the former generate the latter? And why are the generated files committed to the repo? For CI?

@mockersf
Copy link
Copy Markdown
Contributor

mockersf commented May 22, 2022

Yup and yup. If I remember correctly the tests are quite heavy to generate and uses a webbrowser, to generate the assertion values

@alice-i-cecile
Copy link
Copy Markdown
Collaborator Author

alice-i-cecile commented May 23, 2022

With the final release of stretch2, this is now unblocked. I'm going to merge this aggressively; further work should be done in easier-to-review PRs.

@alice-i-cecile alice-i-cecile enabled auto-merge (squash) May 23, 2022 17:55
@alice-i-cecile alice-i-cecile merged commit 7e84a46 into DioxusLabs:main May 23, 2022
jkelleyrtp pushed a commit that referenced this pull request Oct 10, 2022
@alice-i-cecile @TimJentzsch
Prepare for release of new sprawl crate (#53)
1576969 
* Remove JS / Swift / Kotlin bindings

* Remove CircleCI config

* Remove discussion of language bindings from README

* Move testing and benchmarking advice to CONTRIBUTING

* Rewrite README

* Clean up .gitignore

* Update Authors field

* Update crate description and keywords

* Rename stretch2 to sprawl

* Add release notes for sprawl 0.1.0

* Remove use stretch2 as stretch statements from examples

* Allows duplicate headings

* Link to Discussions

Co-authored-by: TimJentzsch <tim-jentzsch@gmx.de>

* Revise wording in Cargo.toml description

Co-authored-by: TimJentzsch <tim-jentzsch@gmx.de>

* Remove redundant line about asking questions using Discussions

* Revert removal of gentest script

* Trivial formatting fixes

Co-authored-by: TimJentzsch <tim-jentzsch@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TimJentzsch TimJentzsch TimJentzsch left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

blocked Cannot be advanced until something else changes breaking-change A change that breaks our public interface code quality Make the code cleaner or prettier. documentation Improvements or additions to documentation meta About the project itself

Projects

None yet

Milestone

Release new crate

3 participants

@alice-i-cecile @TimJentzsch @mockersf