Grid: Fix sizing issues in complex cases#355
Merged
nicoburns merged 2 commits intoDioxusLabs:mainfrom Feb 7, 2023
Merged
Conversation
Collaborator
|
Can you rebase so we can review more easily? |
- Don't constrain grid item's avaiable space based on a grid container's definite available space - Pass estimates from §11.1. Grid Sizing Algorithm as available space rather than known_dimensions - Apply stretch sizing to compute known_dimensions when sizing tracks - Prioritise align/justify self over parent's align/justify items
d546fe1 to
cb7f68a
Compare
Collaborator
Author
Done! |
alice-i-cecile
approved these changes
Feb 7, 2023
Collaborator
alice-i-cecile
left a comment
There was a problem hiding this comment.
Seems like a reasonable set of changes, and good tests like always.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Correctness fixes for the CSS Grid algorithm
Changes made
Note: This PR includes the changes from #354 so #354 should be merged before this one.