Implement §9.9.1. Flex Container Intrinsic Main Sizes#354
Merged
alice-i-cecile merged 19 commits intoDioxusLabs:mainfrom Feb 7, 2023
Merged
Implement §9.9.1. Flex Container Intrinsic Main Sizes#354alice-i-cecile merged 19 commits intoDioxusLabs:mainfrom
alice-i-cecile merged 19 commits intoDioxusLabs:mainfrom
Conversation
…a passed-in known_dimensions or min/max/preferred styles
…der-box not margin-box
… put each item on it's own line
This was referenced Feb 7, 2023
Closed
alice-i-cecile
approved these changes
Feb 7, 2023
Collaborator
alice-i-cecile
left a comment
There was a problem hiding this comment.
Nice to see you fixing up some of the old stretch bugs :D
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #353
Constitues half of #351
Changes made
Implements §9.9.1. Flex Container Intrinsic Main Sizes. It may not quite get all of the edge cases (for example I haven't tested decimal flex-grow/flex-shrink values. But it seems to make most common cases work correctly (and is a strict improvement over the previous code).
Notes
It seems to be a mild performance win (~10%) on the flexbox "deep" and "super deep" benchmark, although it causes a ~5% regression on the flexbox "wide" benchmarks. At some point we probably ought to look at optimising the "wide" case, but the "deep" case definitely seems more realistic in real-world usage so I'm quite happy with these numbers.