Move flex-item and flex-line layout passes to methods instead of closures#209
Merged
alice-i-cecile merged 4 commits intoDioxusLabs:mainfrom Jul 27, 2022
Merged
Conversation
alice-i-cecile
approved these changes
Jul 27, 2022
Collaborator
|
I'm fine to leave the tests for later. |
jkelleyrtp
pushed a commit
that referenced
this pull request
Oct 10, 2022
…ures (#209) * Fix typos * Move closures to methods * Allow many arguments Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #200
Feedback wanted
I'm not quite certain on how to properly test this as testing this would require fully testing the entire layout algorithm first, so I'm leaving it blank for now.