Move hidden_layout() to parent scope#208
Merged
alice-i-cecile merged 8 commits intoDioxusLabs:mainfrom Jul 27, 2022
Merged
Conversation
Weibye
commented
Jul 27, 2022
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
alice-i-cecile
approved these changes
Jul 27, 2022
Collaborator
alice-i-cecile
left a comment
There was a problem hiding this comment.
My suggestion broke your code, but once that's fixed this LGTM.
jkelleyrtp
pushed a commit
that referenced
this pull request
Oct 10, 2022
* Separate out hide_layout * Cleanup formatting * Added change to releases * Fix typo * Improve docs * Cleanup and clarify test * Apply suggestions from code review Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com> * fix incorrect call Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
hidden_layout()does not need to be a locally defined method #201