Make library more usable in a const context#203
Merged
alice-i-cecile merged 9 commits intoDioxusLabs:mainfrom Jul 25, 2022
Merged
Make library more usable in a const context#203alice-i-cecile merged 9 commits intoDioxusLabs:mainfrom
const context#203alice-i-cecile merged 9 commits intoDioxusLabs:mainfrom
Conversation
Collaborator
Author
|
Going to leave this up for a couple days; changes are trivial but if you see this feel free to review. |
nicoburns
requested changes
Jul 22, 2022
jkelleyrtp
pushed a commit
that referenced
this pull request
Oct 10, 2022
* Add FlexboxLayout::DEFAULT constant * Make constructors const where possible * Use Size::NONE instead of Size::undefined() * Stick with Layout::new * More advice on setting up chromedriver * More const builders * Update tests * Fix find-and-replace error in CHANGELOG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
When working with
Stylein Bevy, I noticed that a common pattern was to use..Default::default()on what is nowFlexboxLayout.However, trait methods can't be constant in Rust (yet), so this can't be used to define new constant layout styles.
Changes:
FlexboxLayout::DEFAULT.Context
Upstream tracking issue for the Rustl limitation: rust-lang/rust#63065.
Some builder methods could not be made const because of orlp/slotmap#85.