restore and fix gentest#145
Merged
alice-i-cecile merged 9 commits intoDioxusLabs:mainfrom Jun 11, 2022
Merged
Conversation
Collaborator
|
Can you add those bug fixes to RELEASES.md so users know about the functional changes? |
Collaborator
|
Another request: can you update CONTRIBUTING.md to properly describe how to generate these tests, and add your review advice? |
Contributor
Author
|
done! |
alice-i-cecile
approved these changes
Jun 11, 2022
jkelleyrtp
pushed a commit
that referenced
this pull request
Oct 10, 2022
* fix gentest * regenerate tests * fix doc comment (default value) * simplify rounding * do not take minimum size for flex-basis * revert deleted files * rename * document fixes * update doc on gentest
This was referenced Feb 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Comparing with a browser implementation is the simplest way to ensure results will match what is expected. This can't be done by fuzzing or prop testing as both would mean recoding a flexbox implementation in tests to generate the assertions to validate the "random" values used.
#141 removed the gentlest script which ensure the tests generated from Chrome are up to date. I strongly disagree with this.
Fixes #65
About the comments on maintaining the generated tests. I believe this was a pain because they were updated manually as the script was failing. Now that it's working again, the tests should not be edited by hand: update the script and regenerate them. They can be ignored during reviews. It would probably be best to commit them in a separate commit to help reviewers
If needed, this could be improved using GitHub actions: