Skip to content

Remove dead Direction type#111

Merged
alice-i-cecile merged 1 commit intoDioxusLabs:mainfrom
alice-i-cecile:direction-yeet
Jun 9, 2022
Merged

Remove dead Direction type#111
alice-i-cecile merged 1 commit intoDioxusLabs:mainfrom
alice-i-cecile:direction-yeet

Conversation

@alice-i-cecile
Copy link
Collaborator

Objective

Fixes #110, noticed in #96.

Documenting that the field does nothing seems incorrect, and adding behavior to fix it is out of scope for the initial release.

@alice-i-cecile alice-i-cecile added bug Something isn't working code quality Make the code cleaner or prettier. breaking-change A change that breaks our public interface labels Jun 9, 2022
@alice-i-cecile
Copy link
Collaborator Author

Here's the docs: https://developer.mozilla.org/en-US/docs/Web/CSS/direction

I suspect that Visly was using this data in a closed-source part of their ecosystem. We don't have that constraint, so it's getting cut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change A change that breaks our public interface bug Something isn't working code quality Make the code cleaner or prettier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Direction field on Style has no effect

1 participant