-
Notifications
You must be signed in to change notification settings - Fork 84
Reward to 0 Code #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reward to 0 Code #105
Conversation
gto90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
BouwmanR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cACK
j50ng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK
ycagel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cACK
|
Just tested the changes. These new parameters cause a lot of failed tests when rebased against I would also suggest a second PR in which we just change the default value for The fix of setting the emission to |
This reverts commit cf72801.
SmartArray
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
ycagel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cACK
j50ng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cACK
…cted final subsidy to zero as introduced by #105
…cted final subsidy to zero as introduced by #105
This pull request updates RegTest network settings to the same settings I used in my recent video where I demonstrated a fix for the DGB mining reward decay to go to 0 instead of 1. Also in this pull request, I provide the 1-line fix to make sure the reward goes to 0 and does not stay at 1 infinitely.
Here is a link to the video where I demo the test & prove this fix: https://www.youtube.com/watch?v=BcOOxoHXJ0I
The main issue is caused by 1 line of code:
if (nSubsidy < COIN) { nSubsidy = COIN; }Simply needs to be changed to:
if (nSubsidy < COIN) { nSubsidy = o; }In addition to the regest changes I also changed a few more variables locally to speed up the previous DGB hardfork points. These local changes if anyone wants to test themselves were below, bottom line of each was test change to make network simulate changes faster with regtest mining. Note the below changes are not in this PR, this is just for reference.