-
Notifications
You must be signed in to change notification settings - Fork 8
chore: Update python-copier-template to 3.0.0 #944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #944 +/- ##
==========================================
- Coverage 94.73% 94.69% -0.05%
==========================================
Files 41 41
Lines 2486 2486
==========================================
- Hits 2355 2354 -1
- Misses 131 132 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tpoliaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does blueapi work with 3.13? It may be something in my local environment but trying to run in 3.13 gives several pages of stacktrace that seems to be from aioca not supporting it. The project page doesn't list 3.13 as supported although it might just be out of date.
Looks like I need to update the copier template there first- I'm assuming that it should but we'll find out |
|
Digging into this a bit more, I don't think The same thing with 3.12 runs as expected |
|
I'm not sure if that's not supporting 3.13 or not liking uv, see this issue |
|
That's a different error from using the prebuilt python-build-standalone versions of python at runtime. This one is from the library itself and is reproducible without uv. |
|
Building aioca with Python 3.13 in their CI uses I think we can't merge this until aioca supports 3.13 and for that we'll need epicscorelibs to support it also. |
|
From discussion, we can merge it but only support up to 3.12 for now |
|
Think this was done in #1013 |
|
So it was, thanks |
Currently leaves Pyright strict mode disabled, see #945.
Gives ownership of the project in the dev-portal to all of the DAQ Core team.
Drops support for python 3.10, adds support for 3.13: is this a breaking change for the library applications of blueapi?