chore: Update copier template #1013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accepted all changes other than Python 3.13 as it is not yet supported by dependencies (scanspec, aioca etc)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1013 +/- ##
==========================================
- Coverage 94.86% 94.82% -0.05%
==========================================
Files 41 41
Lines 2493 2493
==========================================
- Hits 2365 2364 -1
- Misses 128 129 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ZohebShaikh
reviewed
May 29, 2025
| author_email: callum.forrester@diamond.ac.uk | ||
| author_name: Callum Forrester | ||
| component_lifecycle: production | ||
| component_owner: user:vid18871 |
Contributor
There was a problem hiding this comment.
Suggested change
| component_owner: user:vid18871 | |
| component_owner: group:default/core-data-acquisition |
Contributor
Author
There was a problem hiding this comment.
Should be changed but maybe in a separate PR? Doesn't really seem related to updating the template.
Contributor
There was a problem hiding this comment.
Can a ticket be created for this ?
Contributor
Author
There was a problem hiding this comment.
Probably but it's small enough that it could be a direct-to-PR change
ZohebShaikh
approved these changes
May 29, 2025
ZohebShaikh
reviewed
May 29, 2025
| --- | ||
|
|
||
| Describe the bug, including a clear and concise description of the expected behavior, the actual behavior and the context in which you encountered it (ideally include details of your environment). | ||
| Describe the bug, including a clear and concise description of the expected behaviour, the actual behavior and the context in which you encountered it (ideally include details of your environment). |
Contributor
There was a problem hiding this comment.
Hopefully we don't seesaw back and forth on americanisms
DiamondJoseph
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accepted all changes other than Python 3.13 as it is not yet supported
by dependencies (scanspec, aioca etc)
See #1014