-
Notifications
You must be signed in to change notification settings - Fork 8
chore: Update to copier template 5.0.0 and uv #1290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1290 +/- ##
=======================================
Coverage 94.93% 94.93%
=======================================
Files 42 42
Lines 2724 2724
=======================================
Hits 2586 2586
Misses 138 138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| distribution_name: blueapi | ||
| docker: true | ||
| docker_debug: true | ||
| docker_debug: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made this decision while updating the copier template- our debug mode has now diverged enough from the version in the copier template as we are instead publishing a container that always contains gdb/debugpy.
| - "--config" | ||
| - "helm/blueapi/.schema.yaml" | ||
|
|
||
| - repo: https://github.com/gitleaks/gitleaks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved this to the final step of the pre-commit, in case somehow the output of another step mutated the contents in a way that made a valid leak. Seemed sensible to have it run finally?
| @@ -0,0 +1 @@ | |||
| 3.11 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now our minimum version of python to support, for the devcontainer and for linting.
This, the matrix in ci.yml and the pyproject.toml are where we should track spec-0.
src/blueapi/cli/scratch.py
Outdated
| str(path), | ||
| ] | ||
| ) | ||
| process = Popen(["uv", "add", "--frozen", "--editable", f"{name} @ {path}"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this out locally with htss-rig-bluesky (which we don't depend on) and bluesky-stomp and it seems to behave as we currently do
| [ | ||
| "python", | ||
| "-m", | ||
| "uv", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I attempted to get this work with uv add --frozen --editable repo.name @ path, but uv does not like "adding" a dependency when you don't have a pyproject.toml for it to be added to. If you use the /workspaces/blueapi I added for debugging, it then does not seemingly install into "the" venv (may be some confusion on my part there)
Closes #957, #1108, #1014, duplicates #1214, #1089