Skip to content

Conversation

@DiamondJoseph
Copy link
Contributor

@DiamondJoseph DiamondJoseph commented Dec 5, 2025

Closes #957, #1108, #1014, duplicates #1214, #1089

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.93%. Comparing base (cc3355f) to head (5c789fb).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1290   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files          42       42           
  Lines        2724     2724           
=======================================
  Hits         2586     2586           
  Misses        138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

distribution_name: blueapi
docker: true
docker_debug: true
docker_debug: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made this decision while updating the copier template- our debug mode has now diverged enough from the version in the copier template as we are instead publishing a container that always contains gdb/debugpy.

- "--config"
- "helm/blueapi/.schema.yaml"

- repo: https://github.com/gitleaks/gitleaks
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this to the final step of the pre-commit, in case somehow the output of another step mutated the contents in a way that made a valid leak. Seemed sensible to have it run finally?

@@ -0,0 +1 @@
3.11
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now our minimum version of python to support, for the devcontainer and for linting.
This, the matrix in ci.yml and the pyproject.toml are where we should track spec-0.

str(path),
]
)
process = Popen(["uv", "add", "--frozen", "--editable", f"{name} @ {path}"])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this out locally with htss-rig-bluesky (which we don't depend on) and bluesky-stomp and it seems to behave as we currently do

[
"python",
"-m",
"uv",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I attempted to get this work with uv add --frozen --editable repo.name @ path, but uv does not like "adding" a dependency when you don't have a pyproject.toml for it to be added to. If you use the /workspaces/blueapi I added for debugging, it then does not seemingly install into "the" venv (may be some confusion on my part there)

@DiamondJoseph DiamondJoseph marked this pull request as ready for review December 5, 2025 13:52
@DiamondJoseph DiamondJoseph requested a review from a team as a code owner December 5, 2025 13:52
@DiamondJoseph DiamondJoseph merged commit bbd9046 into main Dec 5, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trial-adopt migration to uv from copier template

4 participants