fix: Ensure that numtracker headers are not re-used #1202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the headers are only set when they are present but not cleared at the end of a plan (or when they're absent), a request with no headers following a request with headers will re-use the previous users credentials allowing unauthenticated access to running plans. Setting the headers to an empty map if none are present helps ensure tokens cannot be used by other users.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1202 +/- ##
==========================================
- Coverage 94.59% 94.58% -0.01%
==========================================
Files 41 41
Lines 2588 2587 -1
==========================================
- Hits 2448 2447 -1
Misses 140 140 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DiamondJoseph
added a commit
that referenced
this pull request
Dec 9, 2025
Closes [ACQP-474](https://jira.diamond.ac.uk/browse/ACQP-474), [ACQP-475](https://jira.diamond.ac.uk/browse/ACQP-475) by passing authentication information into the TiledWriter, to allow writing to a Tiled that uses proxy OIDC authentication. Also refactors handling of #1201/#1202 Introduces #1296 which can be revisited once the Tiled authz changes have gone in. --------- Co-authored-by: Peter Holloway <peter.holloway@diamond.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the headers are only set when they are present but not cleared at the
end of a plan (or when they're absent), a request with no headers
following a request with headers will re-use the previous users
credentials allowing unauthenticated access to running plans.
Setting the headers to an empty map if none are present helps ensure
tokens cannot be used by other users.
Fixes: #1201