Skip to content

Fix birthday(): add currentMonth and currentDay #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codingricky merged 1 commit into from
Feb 10, 2020
Merged

Fix birthday(): add currentMonth and currentDay #460

codingricky merged 1 commit into from
Feb 10, 2020

Conversation

@BlankSergey
Copy link

@BlankSergey BlankSergey commented Nov 21, 2019 •
edited
Loading

Because it is UI tests sometimes failed with incorrect date
For exapmle: now 2019-11-21
birthday(23, 65) returns 1996-11-26
It is wrong because for birthday 1996-11-26 it is 22 years old now. Not 23

Add to birthday() currentMonth and currentDay because it is tests som…
c5fbba8 
…etimes failed with incorrect date

Add to birthday() currentMonth and currentDay because it is tests sometimes failed with incorrect date

Fix test coverage
@BlankSergey
Copy link
Author

BlankSergey commented Nov 21, 2019

@jmattsson , can you help, please?
CI is unstbale (it was success before).
And coverage magic decreased

@jmattsson
Copy link
Member

jmattsson commented Nov 21, 2019

@BlankSergey Nope, I know nothing about this repo. Never touched it in my life, sorry. You probably meant to tag someone else :)

@beniregev
Copy link

beniregev commented Nov 24, 2019

Why not use Java 8 Time API? All dates will be related to UTC and calculations will be correct. For example: in UTC (a.k.a. GMT) it's 2019-11-25 16:00 and in Hong-Kong it's 2019-11-26 01:00AM. Using Java 8 Time API will give us the correct result for both locations, both timezones, without any effort.

@BlankSergey
Copy link
Author

BlankSergey commented Nov 26, 2019 •
edited
Loading

@BlankSergey Nope, I know nothing about this repo. Never touched it in my life, sorry. You probably meant to tag someone else :)

I'm sorry :)

@BlankSergey
Copy link
Author

BlankSergey commented Nov 26, 2019

Why not use Java 8 Time API? All dates will be related to UTC and calculations will be correct. For example: in UTC (a.k.a. GMT) it's 2019-11-25 16:00 and in Hong-Kong it's 2019-11-26 01:00AM. Using Java 8 Time API will give us the correct result for both locations, both timezones, without any effort.

In CONTRIBUTING.md writes:

Need to maintain compatibility with Java 1.6 (and Android). Therefore any attempt to migrate to 1.6

JDKs and above will not be merged back in.

@codingricky codingricky merged commit 9170081 into DiUS:master Feb 10, 2020
RockyMM added a commit to RockyMM/java-faker that referenced this pull request Jul 22, 2020
@RockyMM
Updating snakeyaml to 1.26 to solve DiUS#460
4a0f245 
https://bitbucket.org/asomov/snakeyaml/issues/377/allow-configuration-for-preventing-billion
@RockyMM RockyMM mentioned this pull request Jul 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BlankSergey @jmattsson @beniregev @codingricky