fix(webapp): improved error handling in remote desktop clients #1456
Conversation
This commit adds the following improvements to the error handling: * `TERMINATED` event terminates the session and shows an error message in the toast in the connection form. * `ERROR` shows an error message as a notification and duplicates it in the console.
Let maintainers know that an action is required on their side
|
webapp/package.json
Outdated
| "@angular/router": "18.2.1", | ||
| "@devolutions/icons": "4.0.8", | ||
| "@devolutions/iron-remote-desktop": "^0.7.0", | ||
| "@devolutions/iron-remote-desktop": "../../ironrdp/web-client/iron-remote-desktop/dist", |
There was a problem hiding this comment.
Waiting for Devolutions/IronRDP#944 to be merged and released
| // Ignore the error, we will handle it in the `onSessionEvent` handler. | ||
| return EMPTY; |
There was a problem hiding this comment.
suggestion: Maybe add a FIXME given the design suggested on Slack.
CBenoit
left a comment
There was a problem hiding this comment.
LGTM. The new version of the dependency is released too!
This commit adds the following improvements to the error handling:
TERMINATEDevent terminates the session and shows an error message in the toast in the connection form.ERRORshows an error message as a notification and duplicates it in the console.