refactor(web): raise TERMINATED event on connection error
#944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes session to not return error on the connection stage. The `iron-remote-desktop` raises `TERMINATED` instead of `ERROR`, because `ERROR` is now handled as non-critical and not closes the session.
Collaborator
Author
|
I think is a thing we discussed a while ago in DM. I will open a PR with the error handling improvement in Devolutions Gateway Standalone soon. I partially need it for the clipboard refactoring. |
Coverage Report 🤖 ⚙️Past: New: Diff: -0.01% [this comment will be updated automatically] |
CBenoit
reviewed
Aug 27, 2025
Member
CBenoit
left a comment
There was a problem hiding this comment.
For this one, review left on Slack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the session to not return an error on the connection stage. The
iron-remote-desktopraisesTERMINATEDinstead ofERROR, becauseERRORis now handled as non-critical and does not close the session.