fix(web)!: replace current clipboard logic with auto and manual clipboard modes #935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lipboard modes This commit adds: * auto clipboard mode. When it's enabled, clipboard will be automatically monitored for changes and updates from the server will be automatically saved to the local clipboard (it's the old logic, nothing has changed) * Manual clipboard mode. One calls dedicated functions to interact with the clipboard.
Collaborator
Author
|
Hi @CBenoit! Could you review when you get a chance? |
Coverage Report 🤖 ⚙️Past: New: Diff: +0.01% [this comment will be updated automatically] |
RRRadicalEdward
pushed a commit
to Devolutions/devolutions-gateway
that referenced
this pull request
Aug 28, 2025
…modes This commit refactors the clipboard part of the Devolutions Gateway Standalone to follow the new API(see Devolutions/IronRDP#935) of the _iron-remote-desktop_. The changes: * Introduce _autoclipboard_ mode, which the user can enable/disable using the connection form. However, it's available only for browsers based on _Blink_ engine. For others, _autoclipboard_ mode is always false. * Add two new buttons to the toolbar that are available when autoclipboard is false: _Save Clipboard_ and _Send Clipboard_. * Add notification for manual clipboard actions. For example, when the user clicks on the _Save Clipboard_ button, the error or success notification will appear informing the user about the operation status.
CBenoit
reviewed
Aug 29, 2025
CBenoit
reviewed
Aug 29, 2025
CBenoit
reviewed
Aug 29, 2025
CBenoit
approved these changes
Aug 29, 2025
Member
CBenoit
left a comment
There was a problem hiding this comment.
LGTM! Nothing blocking, but feel free to open a follow up PR! Thanks!
RRRadicalEdward
pushed a commit
that referenced
this pull request
Aug 29, 2025
CBenoit
pushed a commit
that referenced
this pull request
Aug 29, 2025
RRRadicalEdward
pushed a commit
to Devolutions/devolutions-gateway
that referenced
this pull request
Sep 1, 2025
…modes This commit refactors the clipboard part of the Devolutions Gateway Standalone to follow the new API(see Devolutions/IronRDP#935) of the _iron-remote-desktop_. The changes: * Introduce _autoclipboard_ mode, which the user can enable/disable using the connection form. However, it's available only for browsers based on _Blink_ engine. For others, _autoclipboard_ mode is always false. * Add two new buttons to the toolbar that are available when autoclipboard is false: _Save Clipboard_ and _Send Clipboard_. * Add notification for manual clipboard actions. For example, when the user clicks on the _Save Clipboard_ button, the error or success notification will appear informing the user about the operation status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
When it's enabled, the clipboard will be automatically monitored for changes, and updates from the server will be automatically saved to the local clipboard (this is the old logic; nothing has changed).
One calls dedicated functions to interact with the clipboard.