Skip to content

Allow to customize git author/committer name+email#58

Merged
cole-h merged 4 commits intoDeterminateSystems:mainfrom
armanbilge:feature/custom-git-name-email
Nov 28, 2022
Merged

Allow to customize git author/committer name+email#58
cole-h merged 4 commits intoDeterminateSystems:mainfrom
armanbilge:feature/custom-git-name-email

Conversation

@armanbilge
Copy link
Copy Markdown
Contributor

@armanbilge armanbilge commented Nov 12, 2022

Description

This PR adds additional non-required inputs that allow to customize the name and email used for the commit author and committer.

Checklist
  • Tested functionality against a test repository (see "How to test changes")
  • Added or updated relevant documentation (leave unchecked if not applicable)

@armanbilge armanbilge marked this pull request as ready for review November 12, 2022 19:18
@armanbilge
Copy link
Copy Markdown
Contributor Author

armanbilge commented Nov 12, 2022

Dunno if it counts, but I tested this in:

Using the configuration in:
https://github.com/armanbilge/nimble-agar-steward/blob/85fc256bd85befc57f627bd0852ff01c9d5b926d/.github/workflows/flake.yml

@armanbilge armanbilge mentioned this pull request Nov 12, 2022
Merged
@cole-h
Copy link
Copy Markdown
Member

cole-h commented Nov 28, 2022

I'm terribly sorry for letting this slip through the cracks; I dunno how I missed it!

Looks good to me -- I'll test it in my test repo and then approve + merge if I don't uncover any issues (I doubt I will, but just to be sure)!

@cole-h cole-h force-pushed the feature/custom-git-name-email branch from 2119467 to 23b3338 Compare November 28, 2022 15:59
cole-h
cole-h approved these changes Nov 28, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution! Sorry again for letting this sit for so long.

FYI: I also pushed a commit adding some docs to the README.

@cole-h cole-h merged commit aa092a7 into DeterminateSystems:main Nov 28, 2022
@armanbilge
Copy link
Copy Markdown
Contributor Author

armanbilge commented Nov 28, 2022

No problem at all. Thank you so much! 😃

@cole-h
Copy link
Copy Markdown
Member

cole-h commented Nov 28, 2022

Just released as https://github.com/DeterminateSystems/update-flake-lock/releases/tag/v15 (forgot to do that earlier, oops).

detsys-pr-bot pushed a commit to detsys-pr-bot/update-flake-lock that referenced this pull request Aug 26, 2024
@grahamc
Update detsys-ts for: `Merge pull request DeterminateSystems#58 fro…
420fb2a 
…m DeterminateSystems/collect-crash-logs` (`cf1897a891edc164a8240f469cd56d14364e6be1`)
grahamc added a commit that referenced this pull request Aug 26, 2024
@grahamc
Merge pull request #124 from detsys-pr-bot/detsys-ts-update-cf1897a89…
24f53da 
…1edc164a8240f469cd56d14364e6be1

Update `detsys-ts`: Merge pull request #58 from DeterminateSystems/collect-crash-logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cole-h cole-h cole-h approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@armanbilge @cole-h