Conversation
grahamc
left a comment
There was a problem hiding this comment.
Looking real close, but the nit about cd. I'll send a fixup.
a9e2170 to
1fd4446
Compare
cole-h
left a comment
There was a problem hiding this comment.
Doesn't seem to work as-is for me; no PR gets created.
https://github.com/cole-h/update-flake-lock-test/actions/runs/9020862190/job/24786935346 was run from the HEAD (at the time) of this branch -- notice how no PR was created, as evidenced by the lack of a number in the "echo" step:
https://github.com/cole-h/update-flake-lock-test/actions/runs/9020902721/job/24787061455 was run off of main, a PR was created, and the echo step has a PR number:
cole-h
left a comment
There was a problem hiding this comment.
LGTM, but we should b e prepared to receive issues over the next while about this breaking things that were not tested very deeply.
|
Agreed. |
…om DeterminateSystems/gustavderdrache/write-correlation` (`e252a66f00e041869f7e402e579141f7b8ab1edf`)
…0e041869f7e402e579141f7b8ab1edf Update `detsys-ts`: Merge pull request #101 from DeterminateSystems/gustavderdrache/write-correlation
This PR converts the Action to TypeScript using our
detsys-tsframework.