Update to latest flake-schemas by edolstra · Pull Request #388 · DeterminateSystems/nix-src

edolstra · 2026-03-18T10:33:20Z

Motivation

This adds support for some deprecated output types. See DeterminateSystems/flake-schemas#59.

Context

Summary by CodeRabbit

New Features
- Added defaultApp, defaultPackage, and devShell flake schemas (each includes deprecation guidance toward recommended alternatives).
Behavior
- Attribute resolution now considers the new schemas alongside existing ones, changing candidate attribute path ordering and precedence for devShells/packages.
Bug Fixes
- Improved runtime error handling for missing build outputs (now raises an error instead of an internal assertion).
Tests
- Updated and added tests to reflect new attribute candidates and devShell precedence.

coderabbitai · 2026-03-18T10:33:41Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d28784ca-fe4a-4322-ad82-e072a702e07b

📥 Commits

Reviewing files that changed from the base of the PR and between 50c3cc2 and 3594a9c.

📒 Files selected for processing (3)

src/nix/develop.cc
tests/functional/config.nix.in
tests/functional/flakes/develop.sh

📝 Walkthrough

Walkthrough

Adds helper builders (mkApp, mkPackage, singleDerivationInventory), refactors apps/packages inventories to use them, introduces deprecation-facing public schemas (defaultApp, defaultPackage, devShell) and wires them into schema lookup; updates InstallableFlake attr-path ordering and adjusts related tests and develop runtime behavior.

Changes

Cohort / File(s)	Summary
Flake schema helpers & public schemas `src/libcmd/builtin-flake-schemas.nix`	Add `mkApp`, `mkPackage`, `singleDerivationInventory`; refactor `appsSchema`/`packagesSchema` to use helpers; add `defaultAppSchema`, `defaultPackageSchema`, `devShellSchema` and expose `defaultApp`, `defaultPackage`, `devShell` (with deprecation notes).
Schema integration (attr-path lookup) `src/libcmd/installable-flake.cc`	Insert new schema lookups into InstallableFlake::getAttrPaths order: `defaultApp` after `apps`, `devShell` after `devShells`, and `defaultPackage` after `packages`, affecting candidate attrPath generation order.
Develop error handling `src/nix/develop.cc`	Replace a debug assert for missing `outputs` with a runtime Error throw, changing error handling during derivation RC script generation.
Derivation test helper `tests/functional/config.nix.in`	Add defaulted `outputs` argument to mkDerivation wrapper (`outputs = args.outputs or ["out"]`).
Functional tests: flakes `tests/functional/flakes/develop.sh`, `tests/functional/flakes/dubious-query.sh`	Add tests asserting devShells/devShell/packages precedence; update dubious-query expected error to include `defaultPackage.$system.<attr>` among candidates.

Sequence Diagram(s)

sequenceDiagram
  participant Client as Client
  participant InstallableFlake as InstallableFlake
  participant SchemaRegistry as SchemaRegistry
  participant AttrPathBuilder as AttrPathBuilder

  Client->>InstallableFlake: request attr paths (role, system, attr)
  InstallableFlake->>SchemaRegistry: fetch ordered schemas (including defaultApp/defaultPackage/devShell)
  SchemaRegistry-->>InstallableFlake: ordered schema list
  InstallableFlake->>AttrPathBuilder: build candidate attrPaths from schemas
  AttrPathBuilder-->>InstallableFlake: candidate attrPaths
  InstallableFlake-->>Client: return attrPaths or error with candidates

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Flake schemas #217: Overlaps earlier flake-schemas changes and helpers; directly related.
Add isLegacy flake schema output attribute #381: Modifies flake schema definitions (legacyPackages/isLegacy) and touches similar schema areas.

Suggested reviewers

cole-h
grahamc

Poem

🐇 I hop through flakes and tidy trails,
New helpers craft the app detail,
Defaults whisper where to be found,
Deprecated carrots soft and round,
Hooray — builds bounce homeward bound!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Update to latest flake-schemas' directly and accurately describes the main change: updating flake-schemas to support deprecated output types.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch eelcodolstra/nix-345-support-deprecated-flake-outputs

📝 Coding Plan

Generate coding plan for human review comments

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@tests/functional/flakes/dubious-query.sh`:
- Line 20: The assertion in dubious-query.sh hardcodes x86_64-linux inside the
grepQuiet expected error string; update that expectation to use the existing
$system variable (like the other paths) so the grepQuiet call checks
"defaultPackage.$system.foo?bar" instead of
"defaultPackage.x86_64-linux.foo?bar" to make the test system-agnostic.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 241ee2aa-4753-426a-9eba-c02af83c57d1

📥 Commits

Reviewing files that changed from the base of the PR and between 35a0be5 and 0046d56.

📒 Files selected for processing (3)

src/libcmd/builtin-flake-schemas.nix
src/libcmd/installable-flake.cc
tests/functional/flakes/dubious-query.sh

tests/functional/flakes/dubious-query.sh

github-actions · 2026-03-18T10:37:32Z

🚀 Deployed on https://69babe36a507a890b93911da--determinate-nix.netlify.app

This adds support for some deprecated output types.

coderabbitai bot reviewed Mar 18, 2026

View reviewed changes

tests/functional/flakes/dubious-query.sh Outdated Show resolved Hide resolved

github-actions bot temporarily deployed to pull request March 18, 2026 10:37 Inactive

edolstra added the upload to s3 label Mar 18, 2026

Update to latest flake-schemas

50c3cc2

This adds support for some deprecated output types.

edolstra force-pushed the eelcodolstra/nix-345-support-deprecated-flake-outputs branch from 0046d56 to 50c3cc2 Compare March 18, 2026 12:28

github-actions bot temporarily deployed to pull request March 18, 2026 12:30 Inactive

edolstra added 2 commits March 18, 2026 15:50

nix develop: Fix assertion failure if outputs attribute is missing

825f8b0

Add tests for devShells and devShell

3594a9c

github-actions bot temporarily deployed to pull request March 18, 2026 15:01 Inactive

edolstra mentioned this pull request Mar 18, 2026

Add tests for devShells and devShell flake outputs NixOS/nix#15516

Merged

cole-h approved these changes Mar 18, 2026

View reviewed changes

edolstra added this pull request to the merge queue Mar 18, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 18, 2026

edolstra added this pull request to the merge queue Mar 18, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 18, 2026

edolstra added this pull request to the merge queue Mar 18, 2026

github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 18, 2026

edolstra added this pull request to the merge queue Mar 18, 2026

Merged via the queue into main with commit 2ae19ec Mar 18, 2026
28 checks passed

edolstra deleted the eelcodolstra/nix-345-support-deprecated-flake-outputs branch March 18, 2026 21:37

coderabbitai bot mentioned this pull request Apr 5, 2026

nix develop: Respect legacyPackages #413

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to latest flake-schemas#388

Update to latest flake-schemas#388
edolstra merged 3 commits intomainfrom
eelcodolstra/nix-345-support-deprecated-flake-outputs

edolstra commented Mar 18, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Mar 18, 2026 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

github-actions bot commented Mar 18, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

edolstra commented Mar 18, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Context

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

edolstra commented Mar 18, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 18, 2026 •

edited

Loading

github-actions bot commented Mar 18, 2026 •

edited

Loading