Add support for some deprecated output types#59
Merged
Conversation
defaultPackage, defaultApp and devShell have been deprecated a long time ago, but for compatibility we should still handle them. Also, handle the meta.description field for apps.
📝 WalkthroughWalkthroughIntroduced helper builders ( Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
flake.nix (1)
457-459: Consider using_prefix for unused parameter.The
packageNameparameter is intentionally unused (the name becomes the attribute key inchildren). In idiomatic Nix, prefixing with_signals this intent to readers.♻️ Suggested improvement
children = builtins.mapAttrs ( - packageName: mkPackage isFlakeCheck what systemType + _packageName: mkPackage isFlakeCheck what systemType ) packagesForSystem;🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@flake.nix` around lines 457 - 459, The parameter name `packageName` in the builtins.mapAttrs call is unused; rename it to an underscore-prefixed name (e.g., `_packageName` or `_`) to signal intent. Update the lambda in the `children = builtins.mapAttrs (packageName: mkPackage isFlakeCheck what systemType) packagesForSystem;` expression so the first parameter is `_packageName` (or `_`) while leaving the rest (`mkPackage`, `isFlakeCheck`, `what`, `systemType`, and `packagesForSystem`) unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@flake.nix`:
- Around line 457-459: The parameter name `packageName` in the builtins.mapAttrs
call is unused; rename it to an underscore-prefixed name (e.g., `_packageName`
or `_`) to signal intent. Update the lambda in the `children = builtins.mapAttrs
(packageName: mkPackage isFlakeCheck what systemType) packagesForSystem;`
expression so the first parameter is `_packageName` (or `_`) while leaving the
rest (`mkPackage`, `isFlakeCheck`, `what`, `systemType`, and
`packagesForSystem`) unchanged.
cole-h
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
defaultPackage,defaultAppanddevShellhave been deprecated a long time ago, but for compatibility we should still handle them.Also, handle the
meta.descriptionfield for apps.Summary by CodeRabbit