Skip to content

Remove nix channel placement#304

Merged
Hoverbear merged 3 commits intomainfrom
hoverbear/ds-698-remove-nix-channel-placement
Mar 8, 2023
Merged

Remove nix channel placement#304
Hoverbear merged 3 commits intomainfrom
hoverbear/ds-698-remove-nix-channel-placement

Conversation

@Hoverbear
Copy link
Copy Markdown
Contributor

@Hoverbear Hoverbear commented Mar 6, 2023

Description

We don't need to do this at all!

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear self-assigned this Mar 6, 2023
@Hoverbear Hoverbear changed the title Hoverbear/ds 698 remove nix channel placement Remove nix channel placement Mar 6, 2023
@Hoverbear Hoverbear added this to the v0.6.0 milestone Mar 6, 2023
@Hoverbear Hoverbear marked this pull request as ready for review March 6, 2023 19:37
@Hoverbear Hoverbear requested a review from cole-h March 6, 2023 19:37
cole-h
cole-h approved these changes Mar 6, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. But depending on the 2.14 fallout, we might need to resurrect this for legacy CLI use cases.

@Hoverbear
Copy link
Copy Markdown
Contributor Author

Hoverbear commented Mar 8, 2023

Hmmm, should we block this until we find out?

@cole-h
Copy link
Copy Markdown
Member

cole-h commented Mar 8, 2023

I think it would be fine as-is, but if (when) we switch to 2.14 as the default for this installer, we'll probably want to make sure it's fine this is removed.

@Hoverbear Hoverbear merged commit 5fe7dd9 into main Mar 8, 2023
@Hoverbear Hoverbear deleted the hoverbear/ds-698-remove-nix-channel-placement branch March 8, 2023 17:24
@cole-h cole-h mentioned this pull request Mar 8, 2023
Closed
6 tasks
@Hoverbear Hoverbear mentioned this pull request Mar 8, 2023
Closed
Hoverbear added a commit that referenced this pull request Mar 8, 2023
@Hoverbear
Fix vm/container tests after #304
2282498
@Hoverbear Hoverbear mentioned this pull request Mar 8, 2023
Merged
6 tasks
Hoverbear added a commit that referenced this pull request Mar 8, 2023
@Hoverbear
Fix vm/container tests after #304 (#316)
3f4480a
@cole-h cole-h mentioned this pull request Mar 8, 2023
Merged
3 tasks
@RaitoBezarius
Copy link
Copy Markdown

RaitoBezarius commented May 1, 2023

Does this mean that this installer cannot install channels at all?

@Hoverbear
Copy link
Copy Markdown
Contributor Author

Hoverbear commented May 1, 2023

The installer has no options for channels, no.

@martaver martaver mentioned this pull request Jun 5, 2023
Open
@lucperkins lucperkins mentioned this pull request Jun 16, 2023
Merged
This was referenced May 23, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cole-h cole-h cole-h approved these changes

Assignees

@Hoverbear Hoverbear

Labels

None yet

Projects

None yet

Milestone

v0.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Hoverbear @cole-h @RaitoBezarius