[eslint-scope] update for v9#74066
Closed
fasttime wants to merge 2 commits intoDefinitelyTyped:masterfrom
Closed
Conversation
217ed0a to
d2d0dbe
Compare
Contributor
|
@fasttime Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 74066,
"author": "fasttime",
"headCommitOid": "eb6a9da9568fb9185f9669612fd1e472bb046036",
"mergeBaseOid": "58c1a3a0f80ba685c43aec3606bfebf2faa97d67",
"lastPushDate": "2025-11-12T08:09:09.000Z",
"lastActivityDate": "2025-11-15T05:26:31.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "eslint-scope",
"kind": "edit",
"files": [
{
"path": "types/eslint-scope/eslint-scope-tests.ts",
"kind": "test"
},
{
"path": "types/eslint-scope/index.d.cts",
"kind": "definition"
},
{
"path": "types/eslint-scope/package.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-packagejson) and not moving towards it (check: `peerDependencies`)"
},
{
"path": "types/eslint-scope/tsconfig.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) and not moving towards it (check: `compilerOptions.exactOptionalPropertyTypes`, `compilerOptions.allowSyntheticDefaultImports`)"
}
],
"owners": [
"mysticatea"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "snitin315",
"date": "2025-11-15T05:26:31.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 3521027878,
"ciResult": "pass"
} |
Contributor
|
🔔 @mysticatea — please review this PR in the next few days. Be sure to explicitly select |
This was referenced Nov 12, 2025
snitin315
approved these changes
Nov 15, 2025
Contributor
Author
|
I'm going to close this pull request as there is consensus in ESLint to add built-in types to |
4 tasks
This was referenced Jan 5, 2026
Closed
michaelfaith
added a commit
to michaelfaith/DefinitelyTyped
that referenced
this pull request
Jan 6, 2026
Updated Scope["implicit"] to match the documented interface. Backporting changes that were abandoned in DefinitelyTyped#74066 to v8
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
ScopeManager["addGlobals"]: feat!: Resolve references to globalvar/function, addaddGlobals()eslint/js#682Scope["implicit"]: https://github.com/eslint/js/blob/main/packages/eslint-scope/README.md#properties-1package.json.This pull request updates the types for the the recently released
eslint-scopev9. Here's an overview of the changes:ScopeManager["addGlobals"].Scope["implicit"]to match the documented interface.@types/eslintwith a peer dependency oneslint.Build-related changes:
Scope["type"]:"class-field-initializer" | "class-static-block"were added in fix: add missing scope types toScope.typeeslint/eslint#20110;"TDZ"pending removal (fix: removeTDZscope type eslint/eslint#20231).Definition["type"]:"TDZ"pending removal (fix: removeTDZscope type eslint/eslint#20231)."exactOptionalPropertyTypes": trueto compiler options.