[@types/lodash] Patches `GetFieldType<>` for paths with multiple square… #69696

birdofpreyru · 2024-05-28T15:40:10Z

… brackets...

e.g. consider the path type literal some[sample][path]. Prior to my change the code would come to the statement
P extends `${infer FieldKey}[${infer IndexKey}]` where the types would be inferred like FieldKey = some, IndexKey = sample][path, and it would fail the correct field type deduction.

After my change the updated expression P extends `${infer FieldKey}[${infer IndexKey}]${infer Rest}` infers in such scenario: FieldKey = some, IndexKey = sample, Rest = [path] (i.e. whatever follows the first [] pair will go into Rest), and the updated code block below will correctly deduce the type from there.

And when there is just one pair of brackets in a path, e.g. some[path], the inference will be FieldKey = some, IndexKey = path, Rest = empty string, which will match '' extends Rest condition, and the deduction will go the first branch, the same as before.

Please fill in this template.

Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change.
Follow the advice from the readme.
Avoid common mistakes.
Run pnpm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

Provide a URL to documentation or source code which provides context for the suggested changes: (see explanation above).
If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

… brackets... e.g. consider the path type literal "some[sample][path]". Prior to my change the code would come to the statement "P extends `${infer FieldKey}[${infer IndexKey}]`" where the types would be inferred like FieldKey = "some", IndexKey = "sample][path", and it would fail the correct field type deduction. After my change the updated expression "P extends `${infer FieldKey}[${infer IndexKey}]${infer Rest}`" inferres in such scenario: FieldKey = "some", IndexKey = "sample", Rest = "[path]" (i.e. whatever follows the first [] pair will go into Rest), and the updated code block below will correctly deduce the type from there. And when there is just one pair of brackets in a path, e.g. "some[path]", the inferrence will be FieldKey = "some", IndexKey = "path", Rest = "", which will match "'' extends Rest" condition, and the deduction will go the first branch, the same as before.

typescript-bot · 2024-05-28T15:40:47Z

@birdofpreyru Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment that I will keep updated.

1 package in this PR

lodash — on npm, on unpkg
- owner-approval: @aj-r

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 69696,
  "author": "birdofpreyru",
  "headCommitOid": "e17c8820abaf8c5d4457089cd54dae88ddeb8f10",
  "mergeBaseOid": "fc5c7b7da93f7135d2f45218926e6cc46ca971b9",
  "lastPushDate": "2024-05-28T15:40:10.000Z",
  "lastActivityDate": "2024-06-27T15:57:07.000Z",
  "maintainerBlessed": "Waiting for Code Reviews",
  "mergeOfferDate": "2024-06-27T14:33:50.000Z",
  "mergeRequestDate": "2024-06-27T15:57:07.000Z",
  "mergeRequestUser": "birdofpreyru",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "lodash",
      "kind": "edit",
      "files": [
        {
          "path": "types/lodash/common/object.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/lodash/lodash-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "bczengel",
        "chrootsu",
        "aj-r",
        "e-cloud",
        "thorn0",
        "jtmthf",
        "DomiR",
        "WilliamChelman"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "aj-r",
      "date": "2024-06-27T14:33:12.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2135569461,
  "ciResult": "pass"
}

typescript-bot · 2024-05-28T15:40:49Z

🔔 @bczengel @chrootsu @aj-r @e-cloud @thorn0 @jtmthf @DomiR @WilliamChelman — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

birdofpreyru · 2024-05-28T15:48:51Z

Hey folks, I came across this issue while working on my own ReactJS library, and I have tested it on my end, in my project — see this commit birdofpreyru/react-global-state@8224baf, in particular this:

prior to my change the check on lines 76–77 failed, and with this patch in place it works as expected. I wasn't sure, how to add such test into @types/lodash though (because unfamiliar test setup here), thus unfortunately a test update is not a part of my PR.

Don't hesitate to ping me for any further doubts.

With type T = { [key: string]: string }; type V = T[number]; // equals "string" because JavaScript/TypeScript automatically transforms non-string key values for object indexing into their string representations. before this change type V = GetIndexedField<T, number>; // incorrectly resolved to "undefined" after this change it works correctly: type V = GetIndexedField<T, number>; // resolves to "string"

birdofpreyru · 2024-05-28T22:34:00Z

I added a commit patching GetIndexedField<> for this scenario:

type O = Record<string, string>;
type T1 = O[number]; // T1 equals "string", because TS is aware that non-string key values are auto-casted to their string representations.
type T2 = GetIndexedField<O, number>; // It was producing "undefined" prior to my update, and it correctly produces "string" after it.

Again, I tested it in my project: birdofpreyru/react-global-state@b13a706, in particular:

aj-r

Thanks for the PR. We'll definitely need tests for this, though. Please look in lodash_test.ts and add to the tests for this.

typescript-bot · 2024-05-29T01:49:38Z

@birdofpreyru One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

typescript-bot · 2024-05-29T21:06:00Z

@aj-r Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

birdofpreyru · 2024-05-29T21:13:01Z

Hey @aj-r , as I deep-dived into the testing, I figured out a bunch of edge-cases where previous GetFieldIndex<> implementations did not work (both the original one in this repo, and the previous version of my PR). I ended up completely re-working it, and now it seems to not break any previous test, and also to support some fancy edge-cases now, e.g.

type O = {
  some: { path: 'A' };
  'some.path': 'B';
  'some[weird]key:)': 'C';
};

GetFieldType<O, '[some][path]'>; // 'A', would be undefined before.
GetFieldType<O, '[some].path'>;  // 'A', would be undefined before.
GetFieldType<O, 'some.path'>; // 'A'
GetFieldType<O, '[some.path]'>; // 'B', would be undefined before.

GetFieldType<O, '[some[weird]key:)]'>; // undefined - the brackets inside key name break the parsing, however...
GetFieldType<O, '["some[weird]key:)"]'>; // 'C' - if index value is (double-)quoted, any brackets / dots inside the index are considered a part of key name.

Please, have a look!

aj-r

Wow, this is really good. There's a lot of complexity going on though, so I would like to find ways to simplify it as much as possible for the reader, otherwise this it going to be difficult to maintain. Less is more.

aj-r · 2024-05-30T09:06:59Z

types/lodash/common/object.d.ts

+        : K extends number ? (`${K}` extends keyof T ? T[`${K}`] : undefined)
+
+        // TODO: This is a better variant for the rest of this function,
+        // but it needs TypeScript >= 4.8, and DefinitelyTyped still demands


FYI: 4.7 support will be dropped once 5.5 is released, which should be soon according to the TS team. So one option could be to wait for that and submit the better solution.

types/lodash/common/object.d.ts

types/lodash/lodash-tests.ts

types/lodash/common/object.d.ts

typescript-bot · 2024-05-30T09:43:42Z

@birdofpreyru One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

typescript-bot · 2024-05-30T12:21:39Z

@aj-r Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

birdofpreyru · 2024-05-30T12:30:09Z

@aj-r ignore the bot, I'll do more work and commits here before it merits a review.

I've figured out that GetFieldType<{ key: "value" } | string, "key"> currently (and previously) resolves to undefined, but we actually can make it to resolve into "value" | undefined, thanks to Extract<{ key: "value" } | string, object> resulting in { key: "value" } :)

typescript-bot · 2024-06-22T14:06:10Z

@birdofpreyru The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.

typescript-bot · 2024-06-25T21:17:55Z

@aj-r Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

aj-r

Woohoo, looks like this is finally ready! Just one more comment.

types/lodash/common/object.d.ts

typescript-bot · 2024-06-27T09:48:06Z

@aj-r Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

birdofpreyru · 2024-06-27T15:57:07Z

Ready to merge

valipanahi · 2024-07-10T16:40:28Z

👍

@Parjak39

* 🤖 Merge PR DefinitelyTyped#69843 Update 6.0 and 6.2 definitions by @Parjak39 * 🤖 Merge PR DefinitelyTyped#69673 [@types/node] Fix dns error code types by @jculvey * 🤖 Merge PR DefinitelyTyped#69660 [@types/express-serve-static-core] 🏷️ Add `Promise<void>` to `RequestHandler`'s return type by @NatoBoram * Revert "[@types/express-serve-static-core] 🏷️ Add `Promise<void>` to `RequestHandler`'s return type" (DefinitelyTyped#69845) * 🤖 Merge PR DefinitelyTyped#69832 [webpack-react-component-name] added type definitions by @DorianLatchague * 🤖 Merge PR DefinitelyTyped#69709 [@types/wordpress__block-editor] Allow first param of innerBlocksProps to be output of useBlockProps by @mikeybinns * Offset watchdog crons (DefinitelyTyped#69848) * 🤖 Merge PR DefinitelyTyped#69850 Update @types/bun to 1.1.14 by @calebamiles * 🤖 Merge PR DefinitelyTyped#69839 Add types for random-access-storage by @EvanHahn * 🤖 Merge PR DefinitelyTyped#69826 [@types/chromecast-caf-receiver] Extensible customData types by @steve-taylor * 🤖 Merge PR DefinitelyTyped#69836 add back my user as an owner by @maxiicodes * [office-js][office-js-preview] (OfficeTheme) Document isDarkTheme and themeId properties (DefinitelyTyped#69663) * 🤖 Merge PR DefinitelyTyped#69819 fix(node): child_process:for takes URL by @peterblazejewicz * 🤖 Merge PR DefinitelyTyped#69773 [@types/uuid]: Update for uuid v10 by @joshkel Co-authored-by: Andrew Haines <andrew@haines.org.nz> * 🤖 Merge PR DefinitelyTyped#69853 [@npmcli/arborist] Fix edgesOut and edgesIn types by @forivall * 🤖 Merge PR DefinitelyTyped#69786 add type for ezuikit-js package by @daiwanxing Co-authored-by: daiwanxing <wanxing.dai@coollu.com.cn> * 🤖 Merge PR DefinitelyTyped#69849 [@npmcli/arborist] Fix Node.edgesOut and Define Node.isWorkspace by @russellhaering * 🤖 Merge PR DefinitelyTyped#69872 [@npmcli/arborist] Add Myself as Owner by @russellhaering * 🤖 Merge PR DefinitelyTyped#69860 Add types for random-access-file by @EvanHahn * 🤖 Merge PR DefinitelyTyped#69869 Add missing type definition for `http-link-header` package `toString()` method. by @ddembo * 🤖 Merge PR DefinitelyTyped#69856 feat(node): pass generic function implementation to `mockImplementation` and `mockImplementationOnce` for node:test by @bacebu4 * 🤖 Merge PR DefinitelyTyped#69857 feat(mocha): add missing failZero option by @johanneswuerbach * 🤖 Merge PR DefinitelyTyped#69876 [@types/tabulator-tables] fixed setData for invoking without any parameter as per official docs by @md-redwan-hossain * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#69668 Add riskCorrelationId to @types/braintree-web DataCollector by @arks71 * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#69868 [@types/chromecast-caf-receiver] Add start and end to LiveSeekableRange by @KimmyWFox * 🤖 dprint fmt * 🤖 Update CODEOWNERS * Preemptively fix broken ExpectTypes (DefinitelyTyped#69881) * 🤖 Update support window * [office-js] [office-js-preview] (Word) Get from CDN, close API not on web (DefinitelyTyped#69897) * Bump the github-actions group with 2 updates (DefinitelyTyped#69891) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 🤖 Merge PR DefinitelyTyped#69900 Add missing type definition for package `http-link-header` method `setUnique()`. by @ddembo * 🤖 Merge PR DefinitelyTyped#69767 [gamedig] fix import when using `moduleResolution: node16` by @a-sync * 🤖 Merge PR DefinitelyTyped#69781 [k6] Fix `ResponseBody` type to use `ArrayBuffer` instead of `bytes` by @KOConchobhair * 🤖 Merge PR DefinitelyTyped#69901 [@types/react-instantsearch-dom] Add onFocus to SearchBoxProps by @huyenltnguyen * 🤖 Merge PR DefinitelyTyped#69903 [@types/jqueryui] Button method return types by @Daniel-Knights * [office-js][office-js-preview] (DevicePermission) Clarify values returned by requestPermissions and requestPermissionsAsync (DefinitelyTyped#69854) * [office-js-preview] (Outlook) Document errorMessageMarkdown property (DefinitelyTyped#68642) * 🤖 Merge PR DefinitelyTyped#69735 Node auth users settings update by @randyn * 🤖 Merge PR DefinitelyTyped#69879 [node] events: improve static methods, fix broken reversion by @Renegade334 * 🤖 Merge PR DefinitelyTyped#69887 fix 'frictionStuffness' -> 'frictionStiffness' type on p2 types by @pagoru * 🤖 Merge PR DefinitelyTyped#69892 [webxr] Add missing s for XRInputSourcesChangeEvent by @willeastcott * 🤖 Merge PR DefinitelyTyped#69902 [@types/k6] Type annotations for version v0.52.0 by @joanlopez Co-authored-by: Johan Suleiko Allansson <allansson@gmail.com> * 🤖 Merge PR DefinitelyTyped#69893 [@types/micromatch] Add new negatedExtglob state to result of scan by @sergeiivankov * 🤖 Merge PR DefinitelyTyped#69908 Fix some definitions for qz-tray by @sheck * 🤖 Merge PR DefinitelyTyped#69917 [styled-theming] use new conditional ts-expect-ignore by @jakebailey * 🤖 Merge PR DefinitelyTyped#69918 update Version of bun-types in @types/bun to 1.1.17 by @sk337 * 🤖 Merge PR DefinitelyTyped#69696 [@types/lodash] Patches `GetFieldType<>` for paths with multiple square… by @birdofpreyru * [office-js][office-js-preview] (Outlook) Document instances when inReplyTo returns null (DefinitelyTyped#69910) * 🤖 Merge PR DefinitelyTyped#69687 Add template import type for uniqueId helper by @vstefanovic97 Co-authored-by: vstefanovic97 <stefanoviv@ae.com> * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#69750 fix: typescript compilation error in lib/webdriver.d.ts by @ankianan Co-authored-by: Ankit Anand <ankit.anand@oracle.com> Co-authored-by: Gabriela Araujo Britto <garaujobritto@gmail.com> * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#69936 fix(clownface): improve support iterables in overloads by @tpluscode * 🤖 Merge PR DefinitelyTyped#69725 relay-runtime - Improve type-safety of RecordProxy#getOrCreateLinkedRecord by @JCMais * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#69927 rails__actioncable update createConsumer type to accept function which returns string by @cooljacob204 * 🤖 Merge PR DefinitelyTyped#69935 [postcss-functions] fix plugin options type by @echocrow * 🤖 Merge PR DefinitelyTyped#69613 [WebXR] Add hapticActuators to gamepad on XRInputSource by @sorskoot * 🤖 Merge PR DefinitelyTyped#69729 (@types/exaroton) update exaroton types to 1.11 by @maxiicodes Signed-off-by: Maximilian Hofmann <maxi@maxiicodes.dev> * 🤖 Merge PR DefinitelyTyped#69939 [three] r166 by @Methuselah96 * 🤖 Merge PR DefinitelyTyped#69890 [gapi.client.*] Bulk update Google API namespace by @Maxim-Mazurok * 🤖 Merge PR DefinitelyTyped#69859 chore: upgrade facebook nodejs business sdk to version 20 by @rodinhatokay * 🤖 Merge PR DefinitelyTyped#69942 chore: sync updates to google.maps by @googlemaps-bot Co-authored-by: copybara-service[bot] <copybara-service[bot]@users.noreply.github.com> * 🤖 Merge PR DefinitelyTyped#69948 [micromatch] Remove myself from owners by @glen-84 * 🤖 Merge PR DefinitelyTyped#69949 [oidc-provider] v8.5.0 bump by @panva * 🤖 Merge PR DefinitelyTyped#69905 [@types/picomatch] Add new negatedExtglob state to result of scan by @sergeiivankov Co-authored-by: Sergei Ivankov <sergeiivankov@pm.me> * 🤖 Merge PR DefinitelyTyped#69771 culori: Add XYB colorspace, missing fns, and culori/css + culori/all entry points by @drwpow * Only check watchdog every two hours (DefinitelyTyped#69956) * 🤖 Merge PR DefinitelyTyped#69686 Update index.d.ts by @zulander1 * 🤖 Update CODEOWNERS * Change mergebot links in README (DefinitelyTyped#69968) * 🤖 Merge PR DefinitelyTyped#69866 Allow react resizable axis prop to have type none by @jamcgre * 🤖 Merge PR DefinitelyTyped#69833 [better-sqlite3] Add VirtualTableOptions rows params by @cooolbros * 🤖 Merge PR DefinitelyTyped#69921 [Poool-engage] - Add types for poool Engage by @maximedasilva * 🤖 Merge PR DefinitelyTyped#69969 [sharedb] Add emitter types to `MilestoneDB` by @alecgibson * 🤖 Merge PR DefinitelyTyped#69973 Clerk.io Fix wrong base response key by @tmmgrafikr * 🤖 Merge PR DefinitelyTyped#69873 [cloudflare-turnstile] updated render parameters types as per cloudfl… by @artem328 * 🤖 Merge PR DefinitelyTyped#69979 [oidc-provider] named Provider export, type exports by @panva * [office-js][office-js-preview] (Outlook) Correct inReply property note (DefinitelyTyped#69976) * [office-js][office-js-preview] (Outlook) Add note on supported mailbox types (DefinitelyTyped#69984) * VS Code 1.91 types update (DefinitelyTyped#69985) * 🤖 Merge PR DefinitelyTyped#69982 Update encoding-japanese for v2.2.0 by @syumai * 🤖 Merge PR DefinitelyTyped#69909 Fixed matchings_index and waypoint_index in types/project-osrm__osrm by @torinori * 🤖 Merge PR DefinitelyTyped#69989 Sync latest changes to @types/google-publisher-tag by @publisher-ads-audits-bot Co-authored-by: jimper <jimper@users.noreply.github.com> * 🤖 Merge PR DefinitelyTyped#69895 feat(node): Add mock module by @rozzilla Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com> * 🤖 Merge PR DefinitelyTyped#69947 fix: drop incorrect types for webtorrent org packages: webtorrent, create-torrent, parse-torrent, bittorrent-protocol by @ThaUnknown * Remove contributors with deleted accounts (DefinitelyTyped#69959) Co-authored-by: TypeScript Bot <typescriptbot@microsoft.com> * fix eslint readonly array * 🤖 Merge PR DefinitelyTyped#69922 thunderbird-webext-browser: update of definitions to API version Thunderbird 127.0 by @JimDanner * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#69960 [ramda] bump types-ramda to 0.30.1 by @Harris-Miller * 🤖 Merge PR DefinitelyTyped#69965 add types for [flubber] by @huxulm Co-authored-by: Isabel Duan <isabelduan@microsoft.com> * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#69981 [cli-progress] Add isActive field to bars by @NoahAndrews * 🤖 Merge PR DefinitelyTyped#69995 [telegram-web-app] Update Telegram Web App to API 7.7 by @deptyped * 🤖 Merge PR DefinitelyTyped#69996 style: rewrap doc strings for telegram-web-app by @KnorpelSenf * 🤖 Merge PR DefinitelyTyped#69945 [carbon-components-react] Remove myself from the contributors by @sgregoire * 🤖 Merge PR DefinitelyTyped#69955 [haxball-headless-browser] Fixes setPlayerAvatar by @RicardoPinto26 * 🤖 Merge PR DefinitelyTyped#69913 [@types/jmuxer] Add missing properties to `JMuxer.Options` by @vrumger * 🤖 Merge PR DefinitelyTyped#69951 fix: [facebook-nodejs-business-sdk] constructor type params to optional by @rodinhatokay * 🤖 Merge PR DefinitelyTyped#69966 [shimmer] Remove global `Function` modification by @lforst * 🤖 Update CODEOWNERS * 🤖 Merge PR DefinitelyTyped#69999 [invity-api]: Add default amounts for fiat currencies by @LukasRada * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#69998 bugfix: [facebook-nodejs-business-sdk] add delete function types to classes by @rodinhatokay * 🤖 Merge PR DefinitelyTyped#70003 [Poool-engage] - rename namespace and add display condition by @maximedasilva * 🤖 Merge PR DefinitelyTyped#69975 fix(karma-webpack): make webpackMiddleware optional by @Den-dp * 🤖 Merge PR DefinitelyTyped#69904 [@types/picomatch] Add new `windows` options field by @sergeiivankov Co-authored-by: Sergei Ivankov <sergeiivankov@pm.me> * 🤖 Merge PR DefinitelyTyped#69852 A JsonLdArray is an array of JsonLdObj's not an array with a single JsonLdObj by @agustaf9 * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#70013 fix(sparqljs): inaccurate types of INSERT/DELETE operations by @tpluscode * 🤖 Merge PR DefinitelyTyped#69974 [readable-stream] fix signature of pipe in Duplex class by @JKRhb * 🤖 Merge PR DefinitelyTyped#69944 [@types/set-cookie-parser] Revert updated `sameSite` typings by @nwalters512 * 🤖 Merge PR DefinitelyTyped#69988 feat(aws-lambda): Add generics for stronger typing of CFN/CDK Custom Resource properties by @LucianoTaranto * 🤖 Merge PR DefinitelyTyped#69938 Improved definitions for awesome-notifications by @seebeen Co-authored-by: Isabel Duan <isabelduan@microsoft.com> * 🤖 Merge PR DefinitelyTyped#70014 [plotly.js] Updated types for LayoutAxis and Axis to match current API by @acolvin-h1 * 🤖 Merge PR DefinitelyTyped#70021 [openui5] Update the definition files for OpenUI5 1.126 by @akudev * 🤖 Merge PR DefinitelyTyped#70015 [easy-soap-request] update axios dependency to v1.6.7 by @chimurai * 🤖 Merge PR DefinitelyTyped#70016 [imapflow] Update types for v1.0.164 (`fetchAll` method) by @Remscar * feat(relay-test-utils): update types to match latest version and add option for stricter typing for resolvers (DefinitelyTyped#70020) * [mixpanel-browser] Support api_payload_format for Config object (DefinitelyTyped#69971) * [office-js] [office-js-preview] Update references to right-click (DefinitelyTyped#70023) * 🤖 Merge PR DefinitelyTyped#70009 [`mapbox__mapbox-sdk`] - Add types for missing `@mapbox/mapbox-sdk` and `isochrone` service by @tetarchus * 🤖 Merge PR DefinitelyTyped#70034 [delaunator] Use type parameter correctly on class Delaunator by @dgreensp * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#70033 matter.js -> (small typo) Update index.d.ts by @JoaoGeraldes * 🤖 Merge PR DefinitelyTyped#70025 Update index.d.ts for `keythereum`: Add types of `recover` function by @sircoon4 * 🤖 Merge PR DefinitelyTyped#70024 feat(ws): Enable `addEventListener`/`removeEventListener` to Work with Unions of Event Types by @ITenthusiasm * 🤖 Merge PR DefinitelyTyped#70026 [@types/modesl] - Event getHeader() method returns string | null by @paolopiaggio * 🤖 Merge PR DefinitelyTyped#69978 chore: update woosmap.map by @wgsadmin Co-authored-by: JeanCarriere <JeanCarriere@users.noreply.github.com> * 🤖 Update CODEOWNERS * Update scripts target to es2023 (DefinitelyTyped#70055) * 🤖 Merge PR DefinitelyTyped#69970 [react] Add failing tests for returning `ReactNode` from an async Component by @eps1lon * Bump the github-actions group across 1 directory with 3 updates (DefinitelyTyped#70047) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 🤖 Merge PR DefinitelyTyped#69885 [@types/espree] Update to 10.1.0 by @e6nlaq * 🤖 Merge PR DefinitelyTyped#69787 [carbon-components-react] Ensure forwards compatiblity with React 19 by @eps1lon * 🤖 Merge PR DefinitelyTyped#69788 [react-bootstrap] Ensure forwards compatiblity with React 19 by @eps1lon * 🤖 Merge PR DefinitelyTyped#69894 Cytoscape closeness centrality normalized result by @cneumann * 🤖 dprint fmt * [carbon-components-react] Removing myself from owners. (DefinitelyTyped#70057) * 🤖 Merge PR DefinitelyTyped#69780 [dockerode] add version option for `buildImage` by @mikeseese * 🤖 Merge PR DefinitelyTyped#70042 [@types/critters-webpack-plugin] Update critters-webpack-plugin to 3.0.2 by @Gehbt * 🤖 Merge PR DefinitelyTyped#70039 [lodash] fix _.get return type cannot refer to correct type and default type in nested object with optional fields by @ncnthien * Revert "fix: drop incorrect types for webtorrent org packages: webtorrent, create-torrent, parse-torrent, bittorrent-protocol" (DefinitelyTyped#70059) * 🤖 Merge PR DefinitelyTyped#70012 react-datepicker v7 was migrated to TypeScript, typings no longer needed by @Cerber-Ursi Co-authored-by: Konstantin Bagrov <dev+nodejs@cerbe.ru> * 🤖 Merge PR DefinitelyTyped#70062 zipkin-context-cls: make namespace an optional argument, since it is by @mitchell-merry * 🤖 Merge PR DefinitelyTyped#70035 remove: @fcostarodrigo/walk by @tpluscode * 🤖 Merge PR DefinitelyTyped#70063 chore: update woosmap.map by @wgsadmin Co-authored-by: manz <manz@users.noreply.github.com> * 🤖 Merge PR DefinitelyTyped#70068 chore: update woosmap.map by @wgsadmin Co-authored-by: manz <manz@users.noreply.github.com> * Fix notNeededPackages for fcostarodrigo__walk (DefinitelyTyped#70069) * [mongoose-delete] Raise minimum TS version to 4.9 (DefinitelyTyped#70070) * [tabulator-tables] Update for new export maps upstream (DefinitelyTyped#70071) * 🤖 Merge PR DefinitelyTyped#69941 motion-sensors-polyfill: Correct GyroscopeSensorOptions Inheritance by @GenieTim * 🤖 Merge PR DefinitelyTyped#69820 node crypto sign should accept a private key in jwk format by @omkelderman * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#69934 [ads-client] Allow `null` as `Settings` properties by @crishoj * 🤖 Merge PR DefinitelyTyped#69920 [react-simple-maps] Add missing hook types by @piercemorris * 🤖 Merge PR DefinitelyTyped#70075 Updates types for Recurly.js v4.29.1 by @recurly-integrations Co-authored-by: recurly-integrations <recurly-integrations@users.noreply.github.com> * 🤖 Merge PR DefinitelyTyped#70067 Update ari client. Add missing field protocol_id to Channel by @MGMDelphi * 🤖 Merge PR DefinitelyTyped#70065 [Poool-access][Poool-engage]: add ispoool boolean on every elements, event names and fix some stuff by @maximedasilva * 🤖 Merge PR DefinitelyTyped#70078 Fix Clerk.io Search response by @tmmgrafikr * Update contributors with renamed accounts (DefinitelyTyped#70045) Co-authored-by: TypeScript Bot <typescriptbot@microsoft.com> Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com> * [office-js][office-js-preview] (Outlook) Deprecate entity-based contextual APIs (DefinitelyTyped#69987) * 🤖 Merge PR DefinitelyTyped#70080 [@types/node-cmd] Adding type definitions by @e6nlaq * 🤖 Merge PR DefinitelyTyped#69950 [color-rgba] Fix return type by @MoonE * 🤖 Merge PR DefinitelyTyped#70081 [@types/jquery.validation] Adding customElements to ValidationOptions by @dhobi Co-authored-by: Daniel Hobi <daniel.hobi@swisslearninghub.com> * 🤖 dprint fmt * [office-js] [office-js-preview] (keyboard shortcuts) Ensure that APIs… (DefinitelyTyped#70085) * Update dprint cli (DefinitelyTyped#70092) * 🤖 Merge PR DefinitelyTyped#65463 Add printerSupport to mjml-core by @jimmyfortinx * Make ImportMeta.resolve conditional (DefinitelyTyped#70054) * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#70093 [office-js][office-js-preview] (Outlook) Update recipient limit by @samantharamon * Don't use github search in publisher watchdog (DefinitelyTyped#70095) * 🤖 Merge PR DefinitelyTyped#70087 [d3-3d] add types for d3-3d by @aminya * 🤖 Merge PR DefinitelyTyped#69862 [plotly.js] Make width/height nullable in Plotly.toImage / Plotly.downloadImage by @billylittlefield * 🤖 Merge PR DefinitelyTyped#70053 qrcode-svg: add svg-viewbox option by @mb21 * Update dprint to pick up comment bugfix (DefinitelyTyped#70103) * [chrome-apps] Fix test for TS 5.6 (DefinitelyTyped#70104) * [dom-view-transitions] Fix for TS 5.6 (DefinitelyTyped#70106) * 🤖 Merge PR DefinitelyTyped#70102 [@types/oojs-ui] Refine annotation of OO.ui.Element.ScrollIntoViewConfig by @jwbth * 🤖 Merge PR DefinitelyTyped#70097 Update types for fabric: Add enablePointerEvents as a boolean feature to fabric canvas initialization. by @amoghasgekar * 🤖 Merge PR DefinitelyTyped#70100 [@types/streamtest] Embed types since 3.0.0 by @nfroidure * 🤖 Merge PR DefinitelyTyped#70108 [@types/ttf2woff2] Embed types since 6.0.0 by @nfroidure * 🤖 Update CODEOWNERS * 🤖 Merge PR DefinitelyTyped#70116 chore: update woosmap.map by @wgsadmin Co-authored-by: manz <manz@users.noreply.github.com> * 🤖 Merge PR DefinitelyTyped#69957 [eslint]: update to ESLint v9 by @fasttime Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com> * 🤖 Merge PR DefinitelyTyped#69946 Lazy.js: fix many incorrect types and improve others by @djcsdy * Export inline fragment and condition (DefinitelyTyped#70124) * Fix always-truthy errors (DefinitelyTyped#70126) * 🤖 Merge PR DefinitelyTyped#70121 [cannon] fix typo `isFronmtWheel` to `isFrontWheel` by @bkmashiro * 🤖 dprint fmt * Support forthcoming changes to `Iterator` type in TS 5.6 (DefinitelyTyped#69632) Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com> * 🤖 Merge PR DefinitelyTyped#70111 Add new turndown options field preformattedCode by @hildoer * 🤖 Merge PR DefinitelyTyped#69994 [@types/chrome] Fix Window type in ExtensionSidebarPaneShownEvent by @hamax * 🤖 Merge PR DefinitelyTyped#69993 Adds webhook payload definitions by @jondewoo Co-authored-by: Jonathan Derrough <jonathan.derrough@biojoule.de> * 🤖 Merge PR DefinitelyTyped#69992 Adds Task custom fields definitions by @jondewoo Co-authored-by: Jonathan Derrough <jonathan.derrough@biojoule.de> * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#69899 Add missing type definitions for package `probe-image-size` deep imports. by @ddembo * 🤖 Merge PR DefinitelyTyped#70107 Nise add missing `abort` property by @HarelM * 🤖 Merge PR DefinitelyTyped#70123 [@types/aws-lambda] TransferFamilyAuthorizerEvent Password undefined by @TheRealBenJones * 🤖 Merge PR DefinitelyTyped#70118 chore: sync updates to google.maps by @googlemaps-bot Co-authored-by: copybara-service[bot] <copybara-service[bot]@users.noreply.github.com> * Remove `stuartthomson` from dockerode owners (DefinitelyTyped#70066) * 🤖 Merge PR DefinitelyTyped#70117 Remove 'jump' property from markdown-it type definitions by @surenpoghosian * 🤖 Merge PR DefinitelyTyped#70130 [@types/govuk-frontend] Add new definition for govuk-frontend by @colinrotherham * 🤖 Merge PR DefinitelyTyped#70140 [three] r167 by @Methuselah96 * 🤖 Merge PR DefinitelyTyped#70142 [three] r167 patches by @Methuselah96 * 🤖 Merge PR DefinitelyTyped#70050 [@types/superagent] add form data append options on field function by @j-elmer123 * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#70145 [@types/camelize] fixes types for camelize package by @lukaskral * 🤖 Merge PR DefinitelyTyped#70148 [@mapbox-sdk]: Restrict `SimpleMarker` coordinates type by @jonahallibone * 🤖 Merge PR DefinitelyTyped#70125 [node] Add v22 typings by @Semigradsky Co-authored-by: Renegade334 <contact.9a5d6388@renegade334.me.uk> * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#70082 Update `relay-runtime` environment types to reflect the renaming of `requiredFieldLogger` to `relayFieldLogger` by @levibuzolic * 🤖 Update CODEOWNERS * 🤖 Merge PR DefinitelyTyped#70132 fix: WS server address can be null by @achingbrain * 🤖 Merge PR DefinitelyTyped#69871 [plotly.js] Update types for x and y axis names to match documentation by @mrtnbrst Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com> * 🤖 Merge PR DefinitelyTyped#69983 feat(heic-convert): add type definitions for 2.1.0 version by @leonardlib * [novnc__novnc]: Update RFB module path to match NoVnc v1.5 (DefinitelyTyped#70022) * Add event listeners typings for `fluent-ffmpeg` (DefinitelyTyped#70019) * [`mapbox-gl`] - Add missing `MapOptions` types (DefinitelyTyped#70008) * Remove contributors with deleted accounts (DefinitelyTyped#70158) Co-authored-by: TypeScript Bot <typescriptbot@microsoft.com> * [plotly.js] - Remove mtadams007 from code ownership. (DefinitelyTyped#70162) * 🤖 Merge PR DefinitelyTyped#70128 Updated to v1.31.0 by @tom-schier Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sumaya Hasan <109527897+sumayahasancds@users.noreply.github.com> * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#70144 [mapbox__mapbox-gl-draw] compatibility with MapBox GL js 3.5+ native types by @brookjordan * 🤖 Merge PR DefinitelyTyped#70079 [sharedb] Add `defaultType` and `transformPresence()` by @alecgibson * [office-js][office-js-preview] (Outlook) Remove outdated information from Office.EmailUser (DefinitelyTyped#70135) * 🤖 Merge PR DefinitelyTyped#70149 Update project website URL for voca by @pine * 🤖 Merge PR DefinitelyTyped#70155 [node] Remove post-22.0 features from v22.0.x package by @Renegade334 * 🤖 Merge PR DefinitelyTyped#70166 [node] Add global WebSocket by @Semigradsky * 🤖 Merge PR DefinitelyTyped#70182 [telegram-web-app] add support for Bot API 7.8 by @KnorpelSenf * 🤖 Merge PR DefinitelyTyped#70114 [chai] Fix assorted JSDoc typos by @JoshuaKGoldberg * 🤖 Merge PR DefinitelyTyped#70172 Update clerk.io author by @madsenmm * 🤖 Merge PR DefinitelyTyped#70187 Sync latest changes to @types/google-publisher-tag by @publisher-ads-audits-bot Co-authored-by: jimper <jimper@users.noreply.github.com> * Added quantum-circuit package types (DefinitelyTyped#70171) * Add json-to-go package types (DefinitelyTyped#70186) * Fix `sass-loader` Callback arguments (missing `content`) (DefinitelyTyped#70037) * VS Code 1.92 types update (DefinitelyTyped#70191) * [office-js][office-js-preview] (Outlook) Remove preview string from new Outlook on Windows references (DefinitelyTyped#70168) * 🤖 Merge PR DefinitelyTyped#70161 [@sap/approuter] fixes start config options to match definition by @nbblum * 🤖 Merge PR DefinitelyTyped#70156 [node] Update and clean up `node:test` definitions (v22.0 and previous versions) by @Renegade334 * 🤖 Merge PR DefinitelyTyped#70154 [node] Update typings to v22.1.0 by @Semigradsky * 🤖 dprint fmt * 🤖 Merge PR DefinitelyTyped#70101 react-adal: Updated package.json: Added myself to the list of owners by @dkorolov1 * 🤖 dprint fmt --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Maximilian Hofmann <maxi@maxiicodes.dev> Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com> Co-authored-by: Jakep39 <147739276+Parjak39@users.noreply.github.com> Co-authored-by: James Culveyhouse <jculveyhouse@gmail.com> Co-authored-by: Nato Boram <NatoBoram@users.noreply.github.com> Co-authored-by: Gabriela Araujo Britto <gabrielaa@microsoft.com> Co-authored-by: Dorian Latchague <43975999+DorianLatchague@users.noreply.github.com> Co-authored-by: Mikey Binns <38146638+mikeybinns@users.noreply.github.com> Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Co-authored-by: caleb miles <848394+calebamiles@users.noreply.github.com> Co-authored-by: Evan Hahn <me@evanhahn.com> Co-authored-by: Steve Taylor <mail@stevetaylor.io> Co-authored-by: Maximilian Hofmann <maxi@maxiicodes.dev> Co-authored-by: Sam Ramon <15154970+samantharamon@users.noreply.github.com> Co-authored-by: Piotr Błażejewicz (Peter Blazejewicz) <peterblazejewicz@users.noreply.github.com> Co-authored-by: Josh Kelley <joshkel@gmail.com> Co-authored-by: Andrew Haines <andrew@haines.org.nz> Co-authored-by: Emily Marigold Klassen <760204+forivall@users.noreply.github.com> Co-authored-by: Klein <david377099119@gmail.com> Co-authored-by: daiwanxing <wanxing.dai@coollu.com.cn> Co-authored-by: Russell Haering <russellhaering@gmail.com> Co-authored-by: David Dembo <bootlegneurons@gmail.com> Co-authored-by: bacebu4 <32079387+bacebu4@users.noreply.github.com> Co-authored-by: Johannes Würbach <johannes.wuerbach@googlemail.com> Co-authored-by: Md. Redwan Hossain <redwan.ping@gmail.com> Co-authored-by: TypeScript Bot <typescriptbot@microsoft.com> Co-authored-by: arks71 <62334095+arks71@users.noreply.github.com> Co-authored-by: KimmyWFox <jingyi.wang@foxtel.com.au> Co-authored-by: Elizabeth Samuel <elizs@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Dembo <d.dembo@tricentis.com> Co-authored-by: a-sync <a-sync@users.noreply.github.com> Co-authored-by: Kyle O'Connor <kyle.james.oconnor@gmail.com> Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com> Co-authored-by: Daniel Knights <59598622+Daniel-Knights@users.noreply.github.com> Co-authored-by: Randy Nguyen <randyn@users.noreply.github.com> Co-authored-by: René <Renegade334@users.noreply.github.com> Co-authored-by: Pablo González Rubio <pagoru@gmail.com> Co-authored-by: Will Eastcott <willeastcott@gmail.com> Co-authored-by: Joan López de la Franca Beltran <5459617+joanlopez@users.noreply.github.com> Co-authored-by: Johan Suleiko Allansson <allansson@gmail.com> Co-authored-by: Sergei Ivankov <96142843+sergeiivankov@users.noreply.github.com> Co-authored-by: Nick Sheck <sheck@users.noreply.github.com> Co-authored-by: sk337 <79583517+sk337@users.noreply.github.com> Co-authored-by: Dr. Sergey Pogodin <dr.pogodin@gmail.com> Co-authored-by: Vuk <60734210+vstefanovic97@users.noreply.github.com> Co-authored-by: vstefanovic97 <stefanoviv@ae.com> Co-authored-by: Ankit Anand <ankit.anand@tokopedia.com> Co-authored-by: Ankit Anand <ankit.anand@oracle.com> Co-authored-by: Gabriela Araujo Britto <garaujobritto@gmail.com> Co-authored-by: Tomasz Pluskiewicz <tpluscode@users.noreply.github.com> Co-authored-by: Jonathan Cardoso <me@jonathancardoso.com> Co-authored-by: Jacob Feldman <jacobgfeld@gmail.com> Co-authored-by: Crow <5488190+echocrow@users.noreply.github.com> Co-authored-by: Sorskoot <mental_c@hotmail.com> Co-authored-by: Nathan Bierema <nbierema@gmail.com> Co-authored-by: Maxim Mazurok <maxim@mazurok.com> Co-authored-by: Rodin Hatokay <57593612+rodinhatokay@users.noreply.github.com> Co-authored-by: googlemaps-bot <googlemaps-bot@google.com> Co-authored-by: copybara-service[bot] <copybara-service[bot]@users.noreply.github.com> Co-authored-by: Glen <glen.84@gmail.com> Co-authored-by: Filip Skokan <panva.ip@gmail.com> Co-authored-by: Sergei Ivankov <sergeiivankov@pm.me> Co-authored-by: Drew Powers <drew@pow.rs> Co-authored-by: Rohan Edman <zulander@gmail.com> Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com> Co-authored-by: jamcgre <90063261+jamcgre@users.noreply.github.com> Co-authored-by: Revan <pfwobcke@gmail.com> Co-authored-by: Maxime Da Silva <maximed@poool.fr> Co-authored-by: Alec Gibson <12036746+alecgibson@users.noreply.github.com> Co-authored-by: Tobias Mønster Madsen <67258103+tmmgrafikr@users.noreply.github.com> Co-authored-by: Artem Vozhzhov <vojjov.artem@ya.ru> Co-authored-by: Michael Lively <michaellively00@gmail.com> Co-authored-by: syumai <syumai@gmail.com> Co-authored-by: torinori <55572846+torinori@users.noreply.github.com> Co-authored-by: Google Publisher Tags Bot <publisher-ads-audits-bot@google.com> Co-authored-by: jimper <jimper@users.noreply.github.com> Co-authored-by: Roberto Bianchi <roberto.bianchi@spendesk.com> Co-authored-by: Cas_ <6506529+ThaUnknown@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Isabel Duan <isabelduan@microsoft.com> Co-authored-by: JimDanner <87583812+JimDanner@users.noreply.github.com> Co-authored-by: Harris Miller <harrismillerconsulting@gmail.com> Co-authored-by: Huxulm <huxulm@gmail.com> Co-authored-by: Noah Andrews <10224994+NoahAndrews@users.noreply.github.com> Co-authored-by: deptyped <deptyped@gmail.com> Co-authored-by: KnorpelSenf <shtrog@gmail.com> Co-authored-by: Sébastien <sgregoire@users.noreply.github.com> Co-authored-by: Ricardo Pinto <40843306+RicardoPinto26@users.noreply.github.com> Co-authored-by: Avrumy <contact@lungers.com> Co-authored-by: Luca Forstner <luca.forstner@gmail.com> Co-authored-by: Luky <lukas@rada.email> Co-authored-by: Denis Bendrikov <Denis.Bendrikov@gmail.com> Co-authored-by: Adam Gustafson <agustafson15@gmail.com> Co-authored-by: Jan Romann <jan.romann@uni-bremen.de> Co-authored-by: Nathan Sarang-Walters <nwalters512@gmail.com> Co-authored-by: Luciano <6540591+LucianoTaranto@users.noreply.github.com> Co-authored-by: Sibin Grašić <i.am@sib.ing> Co-authored-by: acolvin-h1 <91495288+acolvin-h1@users.noreply.github.com> Co-authored-by: Andreas Kunz <andreas.kunz@sap.com> Co-authored-by: Steven Chim <655241+chimurai@users.noreply.github.com> Co-authored-by: Zachary <remscar@gmail.com> Co-authored-by: Stanisław <sjwilczynski@users.noreply.github.com> Co-authored-by: ko1ebayev <ko1ebayev.worx@gmail.com> Co-authored-by: tetarchus <8436118+tetarchus@users.noreply.github.com> Co-authored-by: David Greenspan <155814+dgreensp@users.noreply.github.com> Co-authored-by: João Geraldes <jsmgeraldes@gmail.com> Co-authored-by: SEOKHUN KANG <47733258+sircoon4@users.noreply.github.com> Co-authored-by: Isaiah Thomason <47364027+ITenthusiasm@users.noreply.github.com> Co-authored-by: paolopiaggio <paolo.piaggesi@gmail.com> Co-authored-by: wgsadmin <operations@woosmap.com> Co-authored-by: JeanCarriere <JeanCarriere@users.noreply.github.com> Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com> Co-authored-by: sakamotor <120777733+e6nlaq@users.noreply.github.com> Co-authored-by: Carsten Neumann <carsten_neumann@gmx.net> Co-authored-by: Kyle Albert <5498623+kalbert312@users.noreply.github.com> Co-authored-by: Mike Seese <seesemichaelj@gmail.com> Co-authored-by: rgehbt <74761884+Gehbt@users.noreply.github.com> Co-authored-by: Nguyen Cong Nhat Thien <56965006+ncnthien@users.noreply.github.com> Co-authored-by: Cerber-Ursi <dev+node@cerbe.ru> Co-authored-by: Konstantin Bagrov <dev+nodejs@cerbe.ru> Co-authored-by: Mitchell Merry <mitchellmerry145@gmail.com> Co-authored-by: manz <manz@users.noreply.github.com> Co-authored-by: Tim Bernhard <info@bernhard-webstudio.ch> Co-authored-by: Olle Kelderman <omkelderman@gmail.com> Co-authored-by: Christian Rishøj <christian@rishoj.net> Co-authored-by: Pierce James Morris <17671699+piercemorris@users.noreply.github.com> Co-authored-by: recurly-integrations <49795151+recurly-integrations@users.noreply.github.com> Co-authored-by: recurly-integrations <recurly-integrations@users.noreply.github.com> Co-authored-by: MGMDelphi <53331499+MGMDelphi@users.noreply.github.com> Co-authored-by: MoonE <maxi_kroeg@web.de> Co-authored-by: Daniel Hobi <info@danielhobi.ch> Co-authored-by: Daniel Hobi <daniel.hobi@swisslearninghub.com> Co-authored-by: Jimmy Fortin <jimmy.fortin@gmail.com> Co-authored-by: Amin Yahyaabadi <aminyahyaabadi74@gmail.com> Co-authored-by: Billy Littlefield <13475895+billylittlefield@users.noreply.github.com> Co-authored-by: Mauro Bieg <mb21@users.noreply.github.com> Co-authored-by: Jack <33615628+jwbth@users.noreply.github.com> Co-authored-by: amoghasgekar <72576112+amoghasgekar@users.noreply.github.com> Co-authored-by: Nicolas Froidure <nicolas.froidure@gmail.com> Co-authored-by: Francesco Trotta <github@fasttime.org> Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com> Co-authored-by: Daniel Cassidy <mail@danielcassidy.me.uk> Co-authored-by: Robert Balicki <robert.balicki@gmail.com> Co-authored-by: bakamashiro <53376445+bkmashiro@users.noreply.github.com> Co-authored-by: Ron Buckton <ron.buckton@microsoft.com> Co-authored-by: Anthony Hildoer <anthony@bluerival.com> Co-authored-by: Žiga Ham <zigaham@google.com> Co-authored-by: Jonathan Derrough <jonathan.derrough@gmail.com> Co-authored-by: Jonathan Derrough <jonathan.derrough@biojoule.de> Co-authored-by: Harel M <harel.mazor@gmail.com> Co-authored-by: Ben Jones <ben@benjones.io> Co-authored-by: Stuart <stuartthomson@users.noreply.github.com> Co-authored-by: surenpoghosian <56313895+surenpoghosian@users.noreply.github.com> Co-authored-by: Colin Rotherham <work@colinr.com> Co-authored-by: John Elmer Semaya <john.elmer.semaya@gmail.com> Co-authored-by: Lukas Kral <ahoj@lukaskral.eu> Co-authored-by: Jonah Allibone <jonah.allibone@gmail.com> Co-authored-by: Dmitry Semigradsky <semigradskyd@gmail.com> Co-authored-by: Renegade334 <contact.9a5d6388@renegade334.me.uk> Co-authored-by: Levi Buzolic <levibuzolic@gmail.com> Co-authored-by: Alex Potsides <alex@achingbrain.net> Co-authored-by: Martin <54993850+mrtnbrst@users.noreply.github.com> Co-authored-by: Leonardo Lira Becerra <leonardolirabecerra@gmail.com> Co-authored-by: OlivierFL <66562640+OlivierFL@users.noreply.github.com> Co-authored-by: ChinHongTan <52919589+ChinHongTan@users.noreply.github.com> Co-authored-by: Michael Adams <36059111+mtadams007@users.noreply.github.com> Co-authored-by: Tomas Schier <tom-schier@users.noreply.github.com> Co-authored-by: Sumaya Hasan <109527897+sumayahasancds@users.noreply.github.com> Co-authored-by: Brook Jordan <brkjrdn@gmail.com> Co-authored-by: Pine Mizune <pinemz@gmail.com> Co-authored-by: René <9092381+Renegade334@users.noreply.github.com> Co-authored-by: Tobias Mønster Madsen <67258103+madsenmm@users.noreply.github.com> Co-authored-by: Dmytro Sapozhnyk <dimonsuper010@gmail.com> Co-authored-by: LemonNeko <self@lemonneko.moe> Co-authored-by: Cédric Patchane <code@patchane.com> Co-authored-by: Nico Blum <85098790+nbblum@users.noreply.github.com> Co-authored-by: Dmytro Korolov <40392622+dkorolov1@users.noreply.github.com>

typescript-bot added Critical package Untested Change This PR does not touch tests labels May 28, 2024

birdofpreyru mentioned this pull request May 28, 2024

useGlobalState() type deduction works wrong when [] is used in path? birdofpreyru/react-global-state#89

Closed

typescript-bot added the Where is GH Actions? GH Actions didn't give a response to this PR label May 28, 2024

birdofpreyru mentioned this pull request May 28, 2024

Double check why variable types not resolved on composed paths with number pieces birdofpreyru/react-global-state#79

Closed

typescript-bot removed the Where is GH Actions? GH Actions didn't give a response to this PR label May 28, 2024

aj-r suggested changes May 29, 2024

View reviewed changes

typescript-bot added the Revision needed This PR needs code changes before it can be merged. label May 29, 2024

birdofpreyru added 2 commits May 29, 2024 16:33

Patching/testing GetIndexedField<>

7c237b2

Reworked GetFieldType<>

97943a0

typescript-bot removed Revision needed This PR needs code changes before it can be merged. Untested Change This PR does not touch tests labels May 29, 2024

aj-r suggested changes May 30, 2024

View reviewed changes

typescript-bot added the Revision needed This PR needs code changes before it can be merged. label May 30, 2024

birdofpreyru added 2 commits May 30, 2024 13:08

Merge remote-tracking branch 'upstream/master' into lodash

05c8720

Avoid underscores in function names

71d525a

typescript-bot removed the Revision needed This PR needs code changes before it can be merged. label May 30, 2024

Yet another take on GetFieldType<>

24fe3d0

birdofpreyru added 2 commits June 25, 2024 12:33

Merge branch 'master' into lodash

e5a6912

Merge remote-tracking branch 'upstream/master' into lodash

583ee7e

typescript-bot added Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. and removed The CI failed When GH Actions fails labels Jun 25, 2024

aj-r approved these changes Jun 26, 2024

View reviewed changes

types/lodash/common/object.d.ts Outdated Show resolved Hide resolved

typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Jun 26, 2024

Minor correction

e17c882

typescript-bot added Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. and removed Self Merge This PR can now be self-merged by the PR author or an owner Owner Approved A listed owner of this package signed off on the pull request. labels Jun 27, 2024

aj-r approved these changes Jun 27, 2024

View reviewed changes

typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Jun 27, 2024

typescript-bot merged commit 1705046 into DefinitelyTyped:master Jun 27, 2024

aj-r mentioned this pull request Jun 27, 2024

[lodash] Fix GetFieldType indexing for numeric indexes #69457

Closed

7 tasks

97lynk mentioned this pull request Jun 28, 2024

[@types/lodash] Got failed on version 4.17.6 #69932

Closed

[@types/lodash] Patches GetFieldType<> for paths with multiple square… #69696

[@types/lodash] Patches GetFieldType<> for paths with multiple square… #69696

Uh oh!

Conversation

birdofpreyru commented May 28, 2024

Uh oh!

typescript-bot commented May 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

1 package in this PR

Code Reviews

Status

Uh oh!

typescript-bot commented May 28, 2024

Uh oh!

birdofpreyru commented May 28, 2024

Uh oh!

birdofpreyru commented May 28, 2024

Uh oh!

aj-r left a comment

Choose a reason for hiding this comment

Uh oh!

typescript-bot commented May 29, 2024

Uh oh!

typescript-bot commented May 29, 2024

Uh oh!

birdofpreyru commented May 29, 2024

Uh oh!

aj-r left a comment

Choose a reason for hiding this comment

Uh oh!

aj-r May 30, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

typescript-bot commented May 30, 2024

Uh oh!

typescript-bot commented May 30, 2024

Uh oh!

birdofpreyru commented May 30, 2024

Uh oh!

typescript-bot commented Jun 22, 2024

Uh oh!

typescript-bot commented Jun 25, 2024

Uh oh!

aj-r left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

typescript-bot commented Jun 27, 2024

Uh oh!

birdofpreyru commented Jun 27, 2024

Uh oh!

valipanahi commented Jul 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[@types/lodash] Patches `GetFieldType<>` for paths with multiple square… #69696

[@types/lodash] Patches `GetFieldType<>` for paths with multiple square… #69696

typescript-bot commented May 28, 2024 •

edited

Loading