@remcohaszing Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• mdast — on npm, on unpkg (author is owner)
  • owner-approval: @ChristianMurphy, @wooorm

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 69584,
  "author": "remcohaszing",
  "headCommitOid": "19a6fbcb026b7300d6024f5c457b58c8e6f9bfad",
  "mergeBaseOid": "213785ea0d09abc2b89228d0a810e1597fabb18f",
  "lastPushDate": "2024-05-13T08:48:05.000Z",
  "lastActivityDate": "2024-05-14T07:24:57.000Z",
  "mergeOfferDate": "2024-05-13T21:08:32.000Z",
  "mergeRequestDate": "2024-05-14T07:24:57.000Z",
  "mergeRequestUser": "remcohaszing",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "mdast",
      "kind": "edit",
      "files": [
        {
          "path": "types/mdast/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "ChristianMurphy",
        "lujun2",
        "remcohaszing",
        "wooorm",
        "remcohaszing"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2024-05-13T20:05:58.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "ChristianMurphy",
      "date": "2024-05-13T19:40:22.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "wooorm",
      "date": "2024-05-13T08:49:58.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2107001389,
  "ciResult": "pass"
}

Hey @remcohaszing,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

🔔 @ChristianMurphy @lujun2 @wooorm — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Note that this makes your repro of that bug stop working. When this lands, you’d likely want to update that repro / tell people about it!

No, the repro has a lockfile. Also this PR description creates a reference to the issue.

@typescript-bot ping

@remcohaszing: Everything looks good here. I am ready to merge this PR (at 19a6fbc) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@ChristianMurphy, @lujun2, @wooorm: you can do this too.)

Ready to merge