Revert "[@types/react] fix: remove onPointerEnterCapture & onPointerLeaveCapture (#68984)#69005
Revert "[@types/react] fix: remove onPointerEnterCapture & onPointerLeaveCapture (#68984)#69005eps1lon merged 2 commits intoDefinitelyTyped:masterfrom
Conversation
|
@Thulof Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69005,
"author": "Thulof",
"headCommitOid": "62c3375d66a6f332780d5e610f63ae2329ecce9f",
"mergeBaseOid": "f6b37733d6a66dc9794fffebf9a4757008b5faa1",
"lastPushDate": "2024-03-15T14:43:44.000Z",
"lastActivityDate": "2024-03-18T13:23:26.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "react",
"kind": "edit",
"files": [
{
"path": "types/react/v16/index.d.ts",
"kind": "definition"
},
{
"path": "types/react/v17/index.d.ts",
"kind": "definition"
}
],
"owners": [
"johnnyreilly",
"bbenezech",
"pzavolinsky",
"ericanderson",
"DovydasNavickas",
"theruther4d",
"guilhermehubner",
"ferdaber",
"jrakotoharisoa",
"pascaloliv",
"hotell",
"franklixuefei",
"Jessidhia",
"saranshkataria",
"lukyth",
"eps1lon",
"zieka",
"dancerphil",
"dimitropoulos",
"disjukr",
"vhfmag",
"hellatan",
"priyanshurav",
"Semigradsky",
"mattpocock"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "eps1lon",
"date": "2024-03-18T13:15:27.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1999820310,
"ciResult": "pass"
} |
|
🔔 @johnnyreilly @bbenezech @pzavolinsky @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @eps1lon @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @hellatan @priyanshurav @Semigradsky @mattpocock — please review this PR in the next few days. Be sure to explicitly select |
|
@Thulof One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
|
@eps1lon Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
…eaveCapture (DefinitelyTyped#68984)" This reverts commit 73b5985.
We want to highlight this bad type. VSCode will use strike-through text for this prop which may help avoid this handler.
eps1lon
left a comment
There was a problem hiding this comment.
Thank you for sticking with it!
You're welcome, I'm glad I could help. 😄 |
|
This is still not fixed in |
@fzaninotto According to #69243 (review), the change won't be reverted for 18 or next. |
Please see #69006.
This reverts commit 73b5985.
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.If changing an existing definition:
package.json.If removing a declaration:
notNeededPackages.json.