Revert [@types/react] fix: remove onPointerEnterCapture & onPointerLeaveCapture (#68984)#69243
Revert [@types/react] fix: remove onPointerEnterCapture & onPointerLeaveCapture (#68984)#69243silversonicaxel wants to merge 1 commit intoDefinitelyTyped:masterfrom silversonicaxel:fix/typesreact
Conversation
|
@silversonicaxel Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69243,
"author": "silversonicaxel",
"headCommitOid": "496188405567e36e487024a8ef767d73bc56020e",
"mergeBaseOid": "e5d07ac1d28e211291ff804adcf0d18e0002e72d",
"lastPushDate": "2024-04-02T09:47:17.000Z",
"lastActivityDate": "2024-04-02T10:51:54.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "react",
"kind": "edit",
"files": [
{
"path": "types/react/index.d.ts",
"kind": "definition"
},
{
"path": "types/react/ts5.0/index.d.ts",
"kind": "definition"
}
],
"owners": [
"johnnyreilly",
"bbenezech",
"pzavolinsky",
"ericanderson",
"DovydasNavickas",
"theruther4d",
"guilhermehubner",
"ferdaber",
"jrakotoharisoa",
"pascaloliv",
"hotell",
"franklixuefei",
"Jessidhia",
"saranshkataria",
"lukyth",
"eps1lon",
"zieka",
"dancerphil",
"dimitropoulos",
"disjukr",
"vhfmag",
"hellatan",
"priyanshurav",
"Semigradsky",
"mattpocock"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "changereq",
"reviewer": "eps1lon",
"date": "2024-04-02T10:51:54.000Z"
}
],
"mainBotCommentID": 2031554308,
"ciResult": "pass"
} |
|
🔔 @johnnyreilly @bbenezech @pzavolinsky @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @eps1lon @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @hellatan @priyanshurav @Semigradsky @mattpocock — please review this PR in the next few days. Be sure to explicitly select |
eps1lon
left a comment
There was a problem hiding this comment.
We intentionally only reverted types for 16 and 17. The latest release was supposed to be untouched since libraries falsely shipping these events can fix it by publishing again. That isn't usually possible for 16 and 17 since this usually publishing unmaintained versions which is risky.
|
@silversonicaxel One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
Please see #69006.
This reverts commit 73b5985.
A revert was already done, but it was covering partially the files to revert 1bfbd3b.
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.If changing an existing definition:
package.json.If removing a declaration:
notNeededPackages.json.