remove marked by UziTech · Pull Request #66762 · DefinitelyTyped/DefinitelyTyped

UziTech · 2023-09-20T05:53:15Z

Please fill in this template.

Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change.
Follow the advice from the readme.
Avoid common mistakes.
Run npm test <package to test>.

Select one of these and delete the others:

If removing a declaration:

If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
Delete the package's directory.
Add it to notNeededPackages.json.

typescript-bot · 2023-09-20T05:54:01Z

@UziTech Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

2 packages in this PR (and infra files)

marked-terminal — on npm, on unpkg
marked (probably deleted!) — on npm, on unpkg (author is owner)
- owner-approval: @worr, @Toliak, @sarunint
- Config files to check:
  - marked/index.d.mts: edited
  - marked/v3/.eslintrc.json: edited
  - marked/v4/index.d.mts: edited
Infra files
- notNeededPackages.json

Code Reviews

Because this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
✅ A DT maintainer needs to approve changes which affect DT infrastructure (notNeededPackages.json)

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 66762,
  "author": "UziTech",
  "headCommitOid": "1b6d1909f7aeaa3a2db4c768778ae981b5a0f4f9",
  "mergeBaseOid": "d6df71f271f38735049115008ff6b5de169c9450",
  "lastPushDate": "2023-09-20T05:53:15.000Z",
  "lastActivityDate": "2023-10-03T23:25:35.000Z",
  "mergeOfferDate": "2023-10-03T22:16:51.000Z",
  "mergeRequestDate": "2023-10-03T23:25:35.000Z",
  "mergeRequestUser": "UziTech",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "notNeededPackages.json",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "marked-terminal",
      "kind": "edit",
      "files": [
        {
          "path": "types/marked-terminal/marked-terminal-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/marked-terminal/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/marked-terminal/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "bkendall"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "marked",
      "kind": "delete",
      "files": [
        {
          "path": "types/marked/OTHER_FILES.txt",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/marked/index.d.mts",
          "kind": "package-meta",
          "suspect": "edited"
        },
        {
          "path": "types/marked/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/marked/marked-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/marked/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/marked/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/marked/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/marked/v3/.eslintrc.json",
          "kind": "package-meta",
          "suspect": "edited"
        },
        {
          "path": "types/marked/v3/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/marked/v3/marked-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/marked/v3/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/marked/v3/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/marked/v4/OTHER_FILES.txt",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/marked/v4/index.d.mts",
          "kind": "package-meta",
          "suspect": "edited"
        },
        {
          "path": "types/marked/v4/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/marked/v4/marked-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/marked/v4/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/marked/v4/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "worr",
        "BendingBender",
        "CrossR",
        "mwickett",
        "htkzhtm",
        "ezracelli",
        "scandinave",
        "sarunint",
        "UziTech",
        "Toliak",
        "jfcere",
        "MykSto"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "rbuckton",
      "date": "2023-10-03T22:16:02.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "worr",
      "date": "2023-10-01T10:07:11.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "Toliak",
      "date": "2023-10-01T09:34:49.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "sarunint",
      "date": "2023-09-28T19:36:09.000Z",
      "isMaintainer": false
    },
    {
      "type": "stale",
      "reviewer": "sheetalkamat",
      "date": "2023-09-21T18:20:40.000Z",
      "abbrOid": "85959f1"
    }
  ],
  "mainBotCommentID": 1727015269,
  "ciResult": "pass"
}

typescript-bot · 2023-09-20T05:54:03Z

🔔 @bkendall @worr @BendingBender @CrossR @mwickett @htkzhtm @ezracelli @scandinave @sarunint @Toliak @jfcere @MykSto — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

typescript-bot · 2023-09-20T05:56:34Z

@UziTech The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

typescript-bot · 2023-09-21T03:19:37Z

@UziTech The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

typescript-bot · 2023-09-21T03:36:17Z

@UziTech The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

typescript-bot · 2023-09-21T04:17:04Z

@UziTech The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

typescript-bot · 2023-09-21T06:04:04Z

@worr, @Toliak Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

typescript-bot · 2023-09-21T06:04:06Z

@worr, @Toliak Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

sheetalkamat · 2023-09-21T18:20:10Z

types/marked-terminal/marked-terminal-tests.ts

@@ -1,4 +1,4 @@
-import * as marked from 'marked';
+import { marked } from 'marked';


Suggested change

import { marked } from 'marked';

import * as marked from 'marked';

The default export was removed in marked@v4.0.0

This will fail with the error:

Type 'typeof import("/home/runner/work/DefinitelyTyped/DefinitelyTyped/types/marked-terminal/node_modules/marked/lib/marked")' has no call signatures.

sheetalkamat · 2023-09-21T18:20:32Z

types/marked-terminal/tsconfig.json

-        "paths": {
-            "marked": [ "marked/v3" ]
-        },
+        "target": "es6",


Suggested change

"target": "es6",

This is needed since marked uses private methods

error TS18028: Private identifiers are only available when targeting ECMAScript 2015 and higher.

This is ok according to the docs:

You may edit the tsconfig.json to add new test files, to add "target": "es6"

typescript-bot · 2023-09-21T18:21:30Z

@UziTech One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

typescript-bot · 2023-09-27T12:56:12Z

@UziTech Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

typescript-bot · 2023-09-28T04:04:37Z

@sheetalkamat, @worr, @Toliak Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

sarunint

LGTM, and congratulations for getting type definitions into the package itself!

UziTech · 2023-09-29T18:04:30Z

@sheetalkamat can you please approve or respond to my comments? Thanks!

typescript-bot · 2023-10-01T06:46:40Z

Re-ping @bkendall, @BendingBender, @CrossR, @mwickett, @htkzhtm, @ezracelli, @scandinave, @jfcere, @MykSto:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

Toliak

Congratulations for bringing type definitions into the marked itself 🎉

typescript-bot · 2023-10-01T09:35:30Z

@sheetalkamat, @worr Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

worr

Glad to see this wrapped up 😊

typescript-bot · 2023-10-01T10:07:51Z

@sheetalkamat Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

typescript-bot · 2023-10-03T22:16:51Z

@UziTech: Everything looks good here. I am ready to merge this PR (at 1b6d190) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

UziTech · 2023-10-03T23:25:35Z

Ready to merge

remove marked

48cbe24

typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Edits Infrastructure Edits multiple packages Check Config Changes a module config files labels Sep 20, 2023

typescript-bot added the The CI failed When GH Actions fails label Sep 20, 2023

This was referenced Sep 20, 2023

add marked to allowedPackageJsonDependencies.txt microsoft/DefinitelyTyped-tools#735

Merged

docs: remove @types/marked markedjs/marked#2998

Merged

Toliak approved these changes Sep 20, 2023

View reviewed changes

typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Sep 20, 2023

worr approved these changes Sep 20, 2023

View reviewed changes

UziTech force-pushed the remove-marked branch from cfea792 to ee5b71c Compare September 21, 2023 03:13

add marked-terminal dep

aa657d7

UziTech force-pushed the remove-marked branch from ee5b71c to aa657d7 Compare September 21, 2023 03:14

typescript-bot added The CI failed When GH Actions fails and removed The CI failed When GH Actions fails labels Sep 21, 2023

remove marked-terminal paths

0842715

typescript-bot added The CI failed When GH Actions fails and removed Owner Approved A listed owner of this package signed off on the pull request. The CI failed When GH Actions fails labels Sep 21, 2023

add target

f4620a3

typescript-bot added The CI failed When GH Actions fails and removed The CI failed When GH Actions fails labels Sep 21, 2023

use marked 6

1077d34

fix marked import

85959f1

typescript-bot removed the The CI failed When GH Actions fails label Sep 21, 2023

sheetalkamat requested changes Sep 21, 2023

View reviewed changes

typescript-bot added the Revision needed This PR needs code changes before it can be merged. label Sep 21, 2023

typescript-bot added the Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. label Sep 27, 2023

Merge branch 'master' into remove-marked

002b3a1

typescript-bot removed Revision needed This PR needs code changes before it can be merged. Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. labels Sep 28, 2023

order deps

1b6d190

sarunint approved these changes Sep 28, 2023

View reviewed changes

typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Sep 28, 2023

typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Oct 1, 2023

Toliak approved these changes Oct 1, 2023

View reviewed changes

worr approved these changes Oct 1, 2023

View reviewed changes

rbuckton approved these changes Oct 3, 2023

View reviewed changes

typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Oct 3, 2023

typescript-bot merged commit e758842 into DefinitelyTyped:master Oct 3, 2023

		@@ -1,4 +1,4 @@
		import * as marked from 'marked';
		import { marked } from 'marked';

Conversation

UziTech commented Sep 20, 2023

Uh oh!

typescript-bot commented Sep 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2 packages in this PR (and infra files)

Code Reviews

Status

Uh oh!

typescript-bot commented Sep 20, 2023

Uh oh!

typescript-bot commented Sep 20, 2023

Uh oh!

typescript-bot commented Sep 21, 2023

Uh oh!

typescript-bot commented Sep 21, 2023

Uh oh!

typescript-bot commented Sep 21, 2023

Uh oh!

typescript-bot commented Sep 21, 2023

Uh oh!

typescript-bot commented Sep 21, 2023

Uh oh!

sheetalkamat Sep 21, 2023

Choose a reason for hiding this comment

Uh oh!

UziTech Sep 21, 2023

Choose a reason for hiding this comment

Uh oh!

UziTech Sep 21, 2023

Choose a reason for hiding this comment

Uh oh!

sheetalkamat Sep 21, 2023

Choose a reason for hiding this comment

Uh oh!

UziTech Sep 21, 2023

Choose a reason for hiding this comment

Uh oh!

UziTech Sep 21, 2023

Choose a reason for hiding this comment

Uh oh!

typescript-bot commented Sep 21, 2023

Uh oh!

typescript-bot commented Sep 27, 2023

Uh oh!

typescript-bot commented Sep 28, 2023

Uh oh!

sarunint left a comment

Choose a reason for hiding this comment

Uh oh!

UziTech commented Sep 29, 2023

Uh oh!

typescript-bot commented Oct 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Toliak left a comment

Choose a reason for hiding this comment

Uh oh!

typescript-bot commented Oct 1, 2023

Uh oh!

worr left a comment

Choose a reason for hiding this comment

Uh oh!

typescript-bot commented Oct 1, 2023

Uh oh!

typescript-bot commented Oct 3, 2023

Uh oh!

UziTech commented Oct 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

typescript-bot commented Sep 20, 2023 •

edited

Loading

typescript-bot commented Oct 1, 2023 •

edited

Loading