Skip to content

remove marked #66762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typescript-bot merged 8 commits into from
Oct 3, 2023
Merged

remove marked #66762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
48cbe24
remove marked
UziTech Sep 20, 2023
aa657d7
add marked-terminal dep
UziTech Sep 21, 2023
0842715
remove marked-terminal paths
UziTech Sep 21, 2023
f4620a3
add target
UziTech Sep 21, 2023
1077d34
use marked 6
UziTech Sep 21, 2023
85959f1
fix marked import
UziTech Sep 21, 2023
002b3a1
Merge branch 'master' into remove-marked
UziTech Sep 28, 2023
1b6d190
order deps
UziTech Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions notNeededPackages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3149,6 +3149,10 @@
"libraryName": "markdownlint",
"asOfVersion": "0.18.0"
},
"marked": {
"libraryName": "marked",
"asOfVersion": "6.0.0"
},
"match-sorter": {
"libraryName": "match-sorter",
"asOfVersion": "6.0.0"
Expand Down
2 changes: 1 addition & 1 deletion types/marked-terminal/marked-terminal-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import chalk from "chalk";
import * as marked from "marked";
import { marked } from "marked";
import * as TerminalRenderer from "marked-terminal";

marked.setOptions({
Expand Down
3 changes: 2 additions & 1 deletion types/marked-terminal/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"private": true,
"dependencies": {
"chalk": "^2.4.1"
"chalk": "^2.4.1",
"marked": "^6.0.0"
}
}
4 changes: 1 addition & 3 deletions types/marked-terminal/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@
"typeRoots": [
"../"
],
"paths": {
"marked": [ "marked/v3" ]
},
"target": "es6",
Copy link
Copy Markdown
Contributor

@sheetalkamat sheetalkamat Sep 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"target": "es6",

Copy link
Copy Markdown
Contributor Author

@UziTech UziTech Sep 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed since marked uses private methods

error TS18028: Private identifiers are only available when targeting ECMAScript 2015 and higher.

Copy link
Copy Markdown
Contributor Author

@UziTech UziTech Sep 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok according to the docs:

You may edit the tsconfig.json to add new test files, to add "target": "es6"

"types": [],
"noEmit": true,
"forceConsistentCasingInFileNames": true
Expand Down
1 change: 0 additions & 1 deletion types/marked/OTHER_FILES.txt
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion types/marked/index.d.mts
View file
Open in desktop

This file was deleted.

Loading