String#matchAll should return iterable of RegExpExecArray (fixes TypeScript#36788)#66581
String#matchAll should return iterable of RegExpExecArray (fixes TypeScript#36788)#66581nihil-admirari wants to merge 1 commit intoDefinitelyTyped:masterfrom nihil-admirari:master
Conversation
|
@nihil-admirari Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 66581,
"author": "nihil-admirari",
"headCommitOid": "fded4099550d783bc8fca1370485b81c2738b967",
"mergeBaseOid": "7da74815b09b381ca2b61500eec1c989d904e9b8",
"lastPushDate": "2023-09-01T21:00:12.000Z",
"lastActivityDate": "2023-09-01T21:21:58.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "string.prototype.matchall",
"kind": "edit",
"files": [
{
"path": "types/string.prototype.matchall/index.d.ts",
"kind": "definition"
},
{
"path": "types/string.prototype.matchall/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/string.prototype.matchall/string.prototype.matchall-tests.ts",
"kind": "test"
},
{
"path": "types/string.prototype.matchall/ts5.2/index.d.ts",
"kind": "definition"
},
{
"path": "types/string.prototype.matchall/ts5.2/string.prototype.matchall-tests.ts",
"kind": "test"
},
{
"path": "types/string.prototype.matchall/ts5.2/tsconfig.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.lib.0`)"
},
{
"path": "types/string.prototype.matchall/ts5.2/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"peterblazejewicz"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 1703314947,
"ciResult": "fail",
"ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/fded4099550d783bc8fca1370485b81c2738b967/checks?check_suite_id=15742504503"
} |
|
🔔 @peterblazejewicz — please review this PR in the next few days. Be sure to explicitly select |
requires an update to definitions that ship with TypeScript. |
|
@nihil-admirari The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
PR depends on microsoft/TypeScript#55565 to be merged, changed to draft for now |
|
Superseded by #67760 |
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If changing an existing definition: