Update string.prototype.matchall for TS 5.4#67760
Merged
sandersn merged 1 commit intoDefinitelyTyped:masterfrom Dec 4, 2023
Merged
Update string.prototype.matchall for TS 5.4#67760sandersn merged 1 commit intoDefinitelyTyped:masterfrom
sandersn merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
matchAll actually returns RegExpExecArray not RegExpMatchArray -- index and input are not optional.
Contributor
|
@sandersn Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 67760,
"author": "sandersn",
"headCommitOid": "493485797ae9a170fd96f0f14a578db0b1e0fca5",
"mergeBaseOid": "4315b7f96b27ef6a8ba845d8d8808124bae142ce",
"lastPushDate": "2023-12-04T14:59:08.000Z",
"lastActivityDate": "2023-12-04T14:59:08.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "string.prototype.matchall",
"kind": "edit",
"files": [
{
"path": "types/string.prototype.matchall/index.d.ts",
"kind": "definition"
},
{
"path": "types/string.prototype.matchall/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/string.prototype.matchall/string.prototype.matchall-tests.ts",
"kind": "test"
}
],
"owners": [
"peterblazejewicz"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 1838826557,
"ciResult": "pass"
} |
Contributor
|
🔔 @peterblazejewicz — please review this PR in the next few days. Be sure to explicitly select |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matchAll actually returns RegExpExecArray not RegExpMatchArray -- index and input are not optional. TS 5.4 just fixed this, so string.prototype.matchall needs an update too.
Caused by microsoft/TypeScript#55565