Skip to content

Conversation

@JoshuaKGoldberg
Copy link
Collaborator

👋 Hi! This PR is meant to let you know that we're going to be applying formatting automatically to all DefinitelyTyped packages1. This PR is split out of:

This package is particularly huge (>1MB), so we're tagging you in an individual PR as a heads up. Please post here to let us know if you have any workflow needs that auto-formatting might disrupt2.

Cheers! 💖

Footnotes

  1. Note that formatting will be applied as a commit to master after each PR. PRs won't be blocked on any CI check for proper formatting. See Using a formatter for formatting (instead of lint rules) #65993 for more information.

  2. For example, if this package is fully auto-generated (rather than manually edited), subsequent PRs might have a lot of noise from formatting differences. We can exclude it from formatting in that case.

@typescript-bot
Copy link
Contributor

typescript-bot commented Aug 11, 2023

@JoshuaKGoldberg Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a huge PR, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 23 days — it is still unreviewed!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 66363,
  "author": "JoshuaKGoldberg",
  "headCommitOid": "c994adf74eb219fdcf9e51bfb17ee4f079ae7b0c",
  "mergeBaseOid": "77fd45a8acc24b0134624306b279fa45cdec09b3",
  "lastPushDate": "2023-08-11T18:24:03.000Z",
  "lastActivityDate": "2023-08-11T18:24:03.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": true,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "consumer-data-standards",
      "kind": "edit",
      "files": [
        {
          "path": "types/consumer-data-standards/admin/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/consumer-data-standards/banking/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/consumer-data-standards/common/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/consumer-data-standards/dcr/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/consumer-data-standards/energy/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/consumer-data-standards/energy_sdh/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/consumer-data-standards/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/consumer-data-standards/register/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/consumer-data-standards/telco/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "tom-schier"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1675196599,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Untested Change This PR does not touch tests Huge Change labels Aug 11, 2023
@typescript-bot
Copy link
Contributor

🔔 @tom-schier — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Aug 22, 2023
@typescript-bot
Copy link
Contributor

Re-ping @tom-schier:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot
Copy link
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @JoshuaKGoldberg.

(Ping @tom-schier.)

@JoshuaKGoldberg
Copy link
Collaborator Author

Changes separately merged as part of #66361. ✔️

@JoshuaKGoldberg JoshuaKGoldberg deleted the dprint-consumer-data-standards branch September 4, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Huge Change Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. Untested Change This PR does not touch tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants