[carbon__icons-react] ran dprint fmt #66361
Conversation
|
@JoshuaKGoldberg Thank you for submitting this PR! This is a live comment which I will keep updated. This PR might touch some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this? 0 packages in this PR (and possibly others)Note: this PR touches too many files, check it! Code ReviewsThere aren't any other owners of this package, so a DT maintainer will review it. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 23 days — it is still unreviewed! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 66361,
"author": "JoshuaKGoldberg",
"headCommitOid": "1106f1521f35e8e45b2820dace36c7bca8e9b8b2",
"mergeBaseOid": "dfc258b892794239a47ca9bef558214109884695",
"lastPushDate": "2023-08-11T18:23:57.000Z",
"lastActivityDate": "2023-08-29T15:49:35.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": true,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [],
"reviews": [
{
"type": "stale",
"reviewer": "metonym",
"date": "2023-08-11T18:35:30.000Z",
"abbrOid": "ffc4218"
}
],
"mainBotCommentID": 1675196524,
"ciResult": "pass"
} |
|
🔔 @metonym — please review this PR in the next few days. Be sure to explicitly select |
|
@JoshuaKGoldberg The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
@JoshuaKGoldberg Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day! |
|
🔔 @JoshuaKGoldberg — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
|
Re-ping @«anyone?»: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
|
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. formidable (unpkg)was missing the following properties:
as well as these 1 other properties...json |
|
@metonym Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @JoshuaKGoldberg. (Ping @«anyone?».) |
|
Changes separately merged as part of #66361. ✔️ |
👋 Hi! This PR is meant to let you know that we're going to be applying formatting automatically to all DefinitelyTyped packages1. This PR is split out of:
This package is particularly huge (>1MB), so we're tagging you in an individual PR as a heads up. Please post here to let us know if you have any workflow needs that auto-formatting might disrupt2.
Cheers! 💖
Footnotes
Note that formatting will be applied as a commit to
masterafter each PR. PRs won't be blocked on any CI check for proper formatting. See Using a formatter for formatting (instead of lint rules) #65993 for more information. ↩For example, if this package is fully auto-generated (rather than manually edited), subsequent PRs might have a lot of noise from formatting differences. We can exclude it from formatting in that case. ↩