[carbon__pictograms-react] ran dprint fmt #66362
Conversation
|
@JoshuaKGoldberg Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 66362,
"author": "JoshuaKGoldberg",
"headCommitOid": "ff4af3de1a02d2b87faab10f56de3e900c24e368",
"mergeBaseOid": "dfc258b892794239a47ca9bef558214109884695",
"lastPushDate": "2023-08-11T18:24:00.000Z",
"lastActivityDate": "2023-08-29T15:49:47.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "carbon__pictograms-react",
"kind": "edit",
"files": [
{
"path": "types/carbon__pictograms-react/carbon__pictograms-react-tests.tsx",
"kind": "test"
},
{
"path": "types/carbon__pictograms-react/index.d.ts",
"kind": "definition"
}
],
"owners": [
"metonym"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "stale",
"reviewer": "metonym",
"date": "2023-08-11T18:43:52.000Z",
"abbrOid": "339b863"
}
],
"mainBotCommentID": 1675196587,
"ciResult": "fail",
"ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/ff4af3de1a02d2b87faab10f56de3e900c24e368/checks?check_suite_id=15610643092"
} |
|
🔔 @metonym — please review this PR in the next few days. Be sure to explicitly select |
|
@JoshuaKGoldberg The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
🔔 @JoshuaKGoldberg — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
|
Re-ping @metonym: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
|
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. formidable (unpkg)was missing the following properties:
as well as these 1 other properties...json |
|
@JoshuaKGoldberg The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
1 similar comment
|
@JoshuaKGoldberg The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
Changes separately merged as part of #66361. ✔️ |
👋 Hi! This PR is meant to let you know that we're going to be applying formatting automatically to all DefinitelyTyped packages1. This PR is split out of:
This package is particularly huge (>1MB), so we're tagging you in an individual PR as a heads up. Please post here to let us know if you have any workflow needs that auto-formatting might disrupt2.
Cheers! 💖
Footnotes
Note that formatting will be applied as a commit to
masterafter each PR. PRs won't be blocked on any CI check for proper formatting. See Using a formatter for formatting (instead of lint rules) #65993 for more information. ↩For example, if this package is fully auto-generated (rather than manually edited), subsequent PRs might have a lot of noise from formatting differences. We can exclude it from formatting in that case. ↩