[node] Create @legacy tag instead of @deprecated for legacy API#65506
Conversation
|
@Semigradsky Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 65506,
"author": "Semigradsky",
"headCommitOid": "94b0885bf84e703381572aca4c5acc06039b9f1e",
"mergeBaseOid": "8c2cffe7cb60306373512c7a90673a3456325b04",
"lastPushDate": "2023-05-16T09:08:15.000Z",
"lastActivityDate": "2023-05-16T19:51:54.000Z",
"mergeOfferDate": "2023-05-16T19:04:49.000Z",
"mergeRequestDate": "2023-05-16T19:51:54.000Z",
"mergeRequestUser": "Semigradsky",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/buffer.d.ts",
"kind": "definition"
},
{
"path": "types/node/scripts/generate-docs/ast-processing.ts",
"kind": "test"
},
{
"path": "types/node/ts4.8/buffer.d.ts",
"kind": "definition"
},
{
"path": "types/node/ts4.8/url.d.ts",
"kind": "definition"
},
{
"path": "types/node/ts4.8/util.d.ts",
"kind": "definition"
},
{
"path": "types/node/url.d.ts",
"kind": "definition"
},
{
"path": "types/node/util.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/buffer.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/ts4.8/buffer.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/ts4.8/url.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/ts4.8/util.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/url.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/util.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/buffer.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/ts4.8/buffer.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/ts4.8/url.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/ts4.8/util.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/url.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/util.d.ts",
"kind": "definition"
}
],
"owners": [
"Microsoft",
"DefinitelyTyped",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"n-e",
"galkin",
"parambirs",
"eps1lon",
"SimonSchick",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"ZYSzys",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2023-05-16T19:04:05.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1549296960,
"ciResult": "pass"
} |
|
🔔 @microsoft @DefinitelyTyped @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 @mcollina — please review this PR in the next few days. Be sure to explicitly select |
peterblazejewicz
left a comment
There was a problem hiding this comment.
LGTM!
@Semigradsky thanks!
|
@Semigradsky: Everything looks good here. I am ready to merge this PR (at 94b0885) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@microsoft, @DefinitelyTyped, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @SimonSchick, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina: you can do this too.) |
|
Ready to merge |
…of `@deprecated` for legacy API by @Semigradsky
The
legacyis totally not the same asdeprecated- https://nodejs.org/dist/latest-v20.x/docs/api/documentation.html#stability-indexThis change is necessary so as not to confuse users or create inconvenience when using tools such as gund/eslint-plugin-deprecation.
Close #65494