[react] Add types for inert to Experimental release channel
#60822
Conversation
types/react/index.d.ts
Outdated
| hidden?: boolean | undefined; | ||
| id?: string | undefined; | ||
| /** | ||
| * @see https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/inert |
There was a problem hiding this comment.
Do we need a comment in here? None of the other attributes have comments.
There was a problem hiding this comment.
Do we need a comment in here?
It's JSDOC which means it appears in editors supporting it. This helps people understand what this attribute is for.
None of the other attributes have comments.
I don't know why for each. For some there's no useful MDN article. For some people might not have been aware how useful JSDOC can be
9a238d1 to
9ad5d2c
Compare
inert|
@eps1lon Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 641 days — it is still unreviewed! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 60822,
"author": "eps1lon",
"headCommitOid": "9ad5d2ccb5057a16c9926913d130a4e4e482bc32",
"mergeBaseOid": "b0e683d4a7c4aaa3df73b397dcaa4e80bea25cb6",
"lastPushDate": "2022-06-15T16:17:39.000Z",
"lastActivityDate": "2024-03-18T12:42:54.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "react",
"kind": "edit",
"files": [
{
"path": "types/react/experimental.d.ts",
"kind": "definition"
},
{
"path": "types/react/test/experimental.tsx",
"kind": "test"
},
{
"path": "types/react/ts5.0/experimental.d.ts",
"kind": "definition"
},
{
"path": "types/react/ts5.0/test/experimental.tsx",
"kind": "test"
}
],
"owners": [
"johnnyreilly",
"bbenezech",
"pzavolinsky",
"ericanderson",
"DovydasNavickas",
"theruther4d",
"guilhermehubner",
"ferdaber",
"jrakotoharisoa",
"pascaloliv",
"hotell",
"franklixuefei",
"Jessidhia",
"saranshkataria",
"lukyth",
"eps1lon",
"zieka",
"dancerphil",
"dimitropoulos",
"disjukr",
"vhfmag",
"hellatan",
"priyanshurav",
"Semigradsky",
"mattpocock"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "stale",
"reviewer": "votemike",
"date": "2022-06-23T13:05:17.000Z",
"abbrOid": "9a238d1"
}
],
"ciResult": "pass"
} |
|
🔔 @johnnyreilly @bbenezech @pzavolinsky @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @hellatan @priyanshurav @Semigradsky @mattpocock — please review this PR in the next few days. Be sure to explicitly select |
|
@votemike Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @eps1lon. (Ping @johnnyreilly, @bbenezech, @pzavolinsky, @ericanderson, @DovydasNavickas, @theruther4d, @guilhermehubner, @ferdaber, @jrakotoharisoa, @pascaloliv, @Hotell, @franklixuefei, @Jessidhia, @saranshkataria, @lukyth, @zieka, @dancerphil, @dimitropoulos, @disjukr, @vhfmag, @hellatan, @priyanshurav, @Semigradsky, @mattpocock.) |
inert to Experimental release channel
Waiting for release of facebook/react#24730
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
inertprop facebook/react#24730