Skip to content

[node-telegram-bot-api] Fix typo in approveChatJoinRequest#59693

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
MysteryBlokHed:fix-59672-typo
Apr 4, 2022
Merged

[node-telegram-bot-api] Fix typo in approveChatJoinRequest#59693
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
MysteryBlokHed:fix-59672-typo

Conversation

@MysteryBlokHed
Copy link
Copy Markdown
Contributor

Fixes a typo I introduced in #59672 😅

If changing an existing definition:

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 4, 2022

@MysteryBlokHed Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 59693,
  "author": "MysteryBlokHed",
  "headCommitOid": "5ab2ce54a147743b00869e8c533865dba4649c9d",
  "mergeBaseOid": "9654630c0e8da5b3744d65cf7c5b7db2623df934",
  "lastPushDate": "2022-04-04T19:18:44.000Z",
  "lastActivityDate": "2022-04-04T20:55:38.000Z",
  "mergeOfferDate": "2022-04-04T20:36:11.000Z",
  "mergeRequestDate": "2022-04-04T20:55:38.000Z",
  "mergeRequestUser": "MysteryBlokHed",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "node-telegram-bot-api",
      "kind": "edit",
      "files": [
        {
          "path": "types/node-telegram-bot-api/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node-telegram-bot-api/node-telegram-bot-api-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "ammuench",
        "agadar",
        "Dabolus",
        "XC-Zhang",
        "adityathebe",
        "MiklerGM",
        "XieJiSS",
        "toniop99"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "toniop99",
      "date": "2022-04-04T20:35:31.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1087924420,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @ammuench @Agadar @Dabolus @XC-Zhang @adityathebe @MiklerGM @XieJiSS @toniop99 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Apr 4, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

@MysteryBlokHed: Everything looks good here. I am ready to merge this PR (at 5ab2ce5) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@ammuench, @Agadar, @Dabolus, @XC-Zhang, @adityathebe, @MiklerGM, @XieJiSS, @toniop99: you can do this too.)

@MysteryBlokHed
Copy link
Copy Markdown
Contributor Author

Ready to merge

@typescript-bot typescript-bot merged commit a80122f into DefinitelyTyped:master Apr 4, 2022
@MysteryBlokHed MysteryBlokHed deleted the fix-59672-typo branch April 4, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants