[node-telegram-bot-api] Add approveChatJoinRequest and declineChatJoinRequest functions#59672
Conversation
|
@MysteryBlokHed Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 59672,
"author": "MysteryBlokHed",
"headCommitOid": "3b0fc69a94fa5425e207226d6f4dc21c7b9eaedd",
"mergeBaseOid": "907e66cad0cd4fda0a7f0611e115b57df3060cb9",
"lastPushDate": "2022-04-03T14:57:35.000Z",
"lastActivityDate": "2022-04-04T00:53:25.000Z",
"mergeOfferDate": "2022-04-04T00:52:50.000Z",
"mergeRequestDate": "2022-04-04T00:53:25.000Z",
"mergeRequestUser": "XC-Zhang",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "node-telegram-bot-api",
"kind": "edit",
"files": [
{
"path": "types/node-telegram-bot-api/index.d.ts",
"kind": "definition"
},
{
"path": "types/node-telegram-bot-api/node-telegram-bot-api-tests.ts",
"kind": "test"
}
],
"owners": [
"ammuench",
"agadar",
"Dabolus",
"XC-Zhang",
"adityathebe",
"MiklerGM",
"XieJiSS",
"toniop99"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "XC-Zhang",
"date": "2022-04-04T00:52:12.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1086886630,
"ciResult": "pass"
} |
|
🔔 @ammuench @Agadar @Dabolus @XC-Zhang @adityathebe @MiklerGM @XieJiSS @toniop99 — please review this PR in the next few days. Be sure to explicitly select |
XC-Zhang
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks good to me.
|
Ready to merge |
|
@MysteryBlokHed, @XC-Zhang i think there is a typo in the type definitions. node-telegram-bot-api => /src/telegram.js:1282
@types/node-telegram-bot-api => index.d.ts:1277
trying to run the function as wanted by the type produce the following error: VSCode suggestion: |
Related discussion: #59492
npm test node-telegram-bot-api.If changing an existing definition:
approveChatJoinRequest: https://github.com/yagop/node-telegram-bot-api/blob/e114682f2e4b6d65f1772b7b78d260faf3ad1f66/src/telegram.js#L1282declineChatJoinRequest: https://github.com/yagop/node-telegram-bot-api/blob/e114682f2e4b6d65f1772b7b78d260faf3ad1f66/src/telegram.js#L1299