Skip to content

[wordpress__blocks] Updated typings for version 11.0#59512

Merged
typescript-bot merged 6 commits intoDefinitelyTyped:masterfrom
marekdedic:wordpress__blocks-update
Mar 31, 2022
Merged

[wordpress__blocks] Updated typings for version 11.0#59512
typescript-bot merged 6 commits intoDefinitelyTyped:masterfrom
marekdedic:wordpress__blocks-update

Conversation

@marekdedic
Copy link
Copy Markdown
Contributor

@marekdedic marekdedic commented Mar 28, 2022

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@marekdedic
Copy link
Copy Markdown
Contributor Author

Depends on #59511

@DangerBotOSS
Copy link
Copy Markdown

DangerBotOSS commented Mar 30, 2022

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

wordpress__blocks (unpkg)

was missing the following properties:

  1. store

Generated by 🚫 dangerJS against d47919c

@marekdedic marekdedic marked this pull request as ready for review March 30, 2022 17:59
@marekdedic
Copy link
Copy Markdown
Contributor Author

Seems like #59550 fixed the CI issues 🎉

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Mar 30, 2022

@marekdedic Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 59512,
  "author": "marekdedic",
  "headCommitOid": "d47919cb386ca8b26b44bdb5251c0e3d05f772a1",
  "mergeBaseOid": "9c8403fb0784ff4d21e101027a3cd104bcb3a5f7",
  "lastPushDate": "2022-03-31T10:07:58.000Z",
  "lastActivityDate": "2022-03-31T18:16:12.000Z",
  "mergeOfferDate": "2022-03-31T18:08:42.000Z",
  "mergeRequestDate": "2022-03-31T18:16:12.000Z",
  "mergeRequestUser": "marekdedic",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "wordpress__blocks",
      "kind": "edit",
      "files": [
        {
          "path": "types/wordpress__blocks/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__blocks/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "dsifford",
        "sirreal",
        "dmsnell"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "andrewbranch",
      "date": "2022-03-31T18:08:02.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "sirreal",
      "date": "2022-03-31T14:09:16.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1083447640,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @dsifford @sirreal @dmsnell — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Copy link
Copy Markdown
Contributor

@sirreal sirreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version bump looks good, will you provided details about the other change?

@@ -1,4 +1,4 @@
// Type definitions for @wordpress/blocks 9.1
// Type definitions for @wordpress/blocks 11.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@typescript-bot typescript-bot added the Untested Change This PR does not touch tests label Mar 31, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

Hey @marekdedic,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot
Copy link
Copy Markdown
Contributor

@sirreal Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Mar 31, 2022
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Mar 31, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

@marekdedic: Everything looks good here. I am ready to merge this PR (at d47919c) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@dsifford, @sirreal, @dmsnell: you can do this too.)

@marekdedic
Copy link
Copy Markdown
Contributor Author

Ready to merge

@typescript-bot typescript-bot merged commit 98f01e4 into DefinitelyTyped:master Mar 31, 2022
@marekdedic marekdedic deleted the wordpress__blocks-update branch March 31, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants