[wordpress__blocks] Updated typings for version 11.0#59512
[wordpress__blocks] Updated typings for version 11.0#59512typescript-bot merged 6 commits intoDefinitelyTyped:masterfrom marekdedic:wordpress__blocks-update
Conversation
|
Depends on #59511 |
|
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. wordpress__blocks (unpkg)was missing the following properties:
|
|
Seems like #59550 fixed the CI issues 🎉 |
|
@marekdedic Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 59512,
"author": "marekdedic",
"headCommitOid": "d47919cb386ca8b26b44bdb5251c0e3d05f772a1",
"mergeBaseOid": "9c8403fb0784ff4d21e101027a3cd104bcb3a5f7",
"lastPushDate": "2022-03-31T10:07:58.000Z",
"lastActivityDate": "2022-03-31T18:16:12.000Z",
"mergeOfferDate": "2022-03-31T18:08:42.000Z",
"mergeRequestDate": "2022-03-31T18:16:12.000Z",
"mergeRequestUser": "marekdedic",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "wordpress__blocks",
"kind": "edit",
"files": [
{
"path": "types/wordpress__blocks/index.d.ts",
"kind": "definition"
},
{
"path": "types/wordpress__blocks/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"dsifford",
"sirreal",
"dmsnell"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "andrewbranch",
"date": "2022-03-31T18:08:02.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "sirreal",
"date": "2022-03-31T14:09:16.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1083447640,
"ciResult": "pass"
} |
|
🔔 @dsifford @sirreal @dmsnell — please review this PR in the next few days. Be sure to explicitly select |
sirreal
left a comment
There was a problem hiding this comment.
The version bump looks good, will you provided details about the other change?
| @@ -1,4 +1,4 @@ | |||
| // Type definitions for @wordpress/blocks 9.1 | |||
| // Type definitions for @wordpress/blocks 11.0 | |||
There was a problem hiding this comment.
|
Hey @marekdedic, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
|
@sirreal Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
@marekdedic: Everything looks good here. I am ready to merge this PR (at d47919c) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
|
Ready to merge |
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If changing an existing definition: