@marekdedic Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• wordpress__data — on npm, on unpkg

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 59511,
  "author": "marekdedic",
  "headCommitOid": "f1d1c17e0391aedd7a433e35bb0b33c2a0a52e19",
  "mergeBaseOid": "dd762e31d8b7a6a469e09ad9f621eb21f864b058",
  "lastPushDate": "2022-03-31T09:44:08.000Z",
  "lastActivityDate": "2022-04-07T06:20:32.000Z",
  "mergeOfferDate": "2022-04-06T23:53:36.000Z",
  "mergeRequestDate": "2022-04-07T06:20:32.000Z",
  "mergeRequestUser": "marekdedic",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "wordpress__data",
      "kind": "edit",
      "files": [
        {
          "path": "types/wordpress__data/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wordpress__data/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "dsifford",
        "sirreal"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "rbuckton",
      "date": "2022-04-06T23:52:57.000Z",
      "isMaintainer": true
    },
    {
      "type": "stale",
      "reviewer": "sirreal",
      "date": "2022-03-30T18:25:16.000Z",
      "abbrOid": "f8172a7"
    }
  ],
  "mainBotCommentID": 1080605692,
  "ciResult": "pass"
}

Hey @marekdedic,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

🔔 @dsifford @sirreal — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@marekdedic The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@marekdedic The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

Ok, I don'ŧ know why, but tests for multiple WP packages are broken. Should I try to fix them in this PR? They were broken before I started doing anything, however, I'm okay with fixing them - but that would make this PR touch several packages :/

This is probably related to #59550...

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

wordpress__data (unpkg)

was missing the following properties:

1. AsyncModeProvider
2. controls

Generated by 🚫 dangerJS against f1d1c17

Seems like #59550 fixed the CI issues 🎉

Hi,
thanks for the correction in package version. As for the API change, see the changelog, the changes are done based on that and the package source.

@sirreal Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@marekdedic: Everything looks good here. I am ready to merge this PR (at f1d1c17) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@dsifford, @sirreal: you can do this too.)

Ready to merge