@eps1lon Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• react-scroll — on npm, on unpkg
  • owner-approval: @SudoPlz

Code Reviews

Because you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 59149,
  "author": "eps1lon",
  "headCommitOid": "8560f2d135dbc2fdc9a7f6feed26490689aeb91c",
  "mergeBaseOid": "37a4b826960a0fd4a6d060e446a9777a608fac6a",
  "lastPushDate": "2022-03-05T10:53:58.000Z",
  "lastActivityDate": "2022-03-16T13:47:09.000Z",
  "mergeOfferDate": "2022-03-16T13:40:59.000Z",
  "mergeRequestDate": "2022-03-16T13:47:09.000Z",
  "mergeRequestUser": "eps1lon",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "react-scroll",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-scroll/test/react-scroll-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "sudoplz",
        "GiedriusGrabauskas"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "SudoPlz",
      "date": "2022-03-16T13:40:08.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1059743746,
  "ciResult": "pass"
}

🔔 @SudoPlz @GiedriusGrabauskas — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Re-ping @SudoPlz, @GiedriusGrabauskas:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@eps1lon: Everything looks good here. I am ready to merge this PR (at 8560f2d) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@SudoPlz, @GiedriusGrabauskas: you can do this too.)

Ready to merge