@peterblazejewicz Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• node-fetch — on npm, on unpkg
  • owner-approval: @glasser

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 58804,
  "author": "peterblazejewicz",
  "headCommitOid": "bb42125bbb73dc49194ac59927e77f6a47433ac3",
  "mergeBaseOid": "24308482dd19406877bb52bfed03d84c8168d457",
  "lastPushDate": "2022-02-15T19:10:06.000Z",
  "lastActivityDate": "2022-02-15T19:45:43.000Z",
  "mergeOfferDate": "2022-02-15T19:44:38.000Z",
  "mergeRequestDate": "2022-02-15T19:45:43.000Z",
  "mergeRequestUser": "peterblazejewicz",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node-fetch",
      "kind": "edit",
      "files": [
        {
          "path": "types/node-fetch/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "torstenwerner",
        "nikcorg",
        "vinaybedre",
        "kyranet",
        "AndrewLeedham",
        "JasonLi914",
        "southpolesteve",
        "ExE-Boss",
        "alexandrusavin",
        "OmgImAlexis",
        "kbkk",
        "glasser"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "andrewbranch",
      "date": "2022-02-15T19:44:00.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "glasser",
      "date": "2022-02-15T19:18:14.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1040620786,
  "ciResult": "pass"
}

🔔 @torstenwerner @nikcorg @vinaybedre @kyranet @AndrewLeedham @JasonLi914 @southpolesteve @ExE-Boss @alexandrusavin @OmgImAlexis @kbkk @glasser — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@peterblazejewicz The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

Well it does appear that this PR isn't quite correct for the reasons that CI is saying, though I suspect you know better than me how to fix it!

Worth noting that node-fetch 2.x only has a dev dep on form-data, so maybe we don't need to take its constraint so seriously and we can change our constraint to be form-data@2.5?

Ah, there is no @types/form-data 2.3 :)

So you can change this to @types/form-data@2.2 or to form-data@2.5.0. Comparing the .d.ts file, the only difference is that form-data@2.5.0 does add a getBuffer() method to FormData, so I guess that is a bit backwards-incompatible. That said, 2.5.0 came out 3 years ago, so it does seem likely that most people are on it in practice?

what a mess, there is 2.2.1:
https://unpkg.com/@types/form-data@2.2.1/index.d.ts

@glasser amended to 2.2.1 (@types/form-data).
btw. This is what I meant when mentioning 3rd party deps problems

@peterblazejewicz The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

OK, so it was never added to white listed types (a bummer), the only option for now is either to wait and whitelist @types/form-data or use form-data@2.5.0 @glasser mentioned. Thoughts?

@glasser Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@glasser Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@andrewbranch, at your discretion, please!

@peterblazejewicz: Everything looks good here. I am ready to merge this PR (at bb42125) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@torstenwerner, @nikcorg, @vinaybedre, @kyranet, @AndrewLeedham, @JasonLi914, @southpolesteve, @ExE-Boss, @alexandrusavin, @OmgImAlexis, @kbkk, @glasser: you can do this too.)

Ready to merge 💘