remove(express-handlebars): no longer needed#57137
Merged
weswigham merged 1 commit intoDefinitelyTyped:masterfrom Nov 16, 2021
Merged
remove(express-handlebars): no longer needed#57137weswigham merged 1 commit intoDefinitelyTyped:masterfrom
weswigham merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
Contributor
|
@peterblazejewicz Thank you for submitting this PR! This is a live comment which I will keep updated. This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this? 2 packages in this PR (and infra files)
Code ReviewsBecause this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 57137,
"author": "peterblazejewicz",
"headCommitOid": "3114bd9f41e2ab78022fc114b9e59791462504b0",
"lastPushDate": "2021-11-15T20:33:13.000Z",
"lastActivityDate": "2021-11-15T20:33:13.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "notNeededPackages.json",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "express-handlebars",
"kind": "delete",
"files": [
{
"path": "types/express-handlebars/express-handlebars-tests.ts",
"kind": "test"
},
{
"path": "types/express-handlebars/index.d.ts",
"kind": "definition"
},
{
"path": "types/express-handlebars/lib/express-handlebars.d.ts",
"kind": "definition"
},
{
"path": "types/express-handlebars/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/express-handlebars/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"stpettersens",
"yhaskell",
"dcbartlett"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "nodemailer-express-handlebars",
"kind": "edit",
"files": [
{
"path": "types/nodemailer-express-handlebars/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"th3rius"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 968090625,
"ciResult": "pass"
} |
Contributor
|
🔔 @stpettersens @yhaskell @dcbartlett @th3rius — please review this PR in the next few days. Be sure to explicitly select |
4ee4a45 to
9f88ee8
Compare
Contributor
|
@peterblazejewicz The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
peterblazejewicz
added a commit
to peterblazejewicz/DefinitelyTyped-tools
that referenced
this pull request
Nov 13, 2021
Required for removal of `express-handlebars` on DT for 3rd party DT package tests: DefinitelyTyped/DefinitelyTyped#57137 Thanks!
Member
Author
|
depends on: |
andrewbranch
pushed a commit
to microsoft/DefinitelyTyped-tools
that referenced
this pull request
Nov 15, 2021
Required for removal of `express-handlebars` on DT for 3rd party DT package tests: DefinitelyTyped/DefinitelyTyped#57137 Thanks!
No longed needed as of v6.0.0: https://github.com/express-handlebars/express-handlebars/releases/tag/v6.0.0 Thanks!
9f88ee8 to
3114bd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No longed needed as of v6.0.0:
https://github.com/express-handlebars/express-handlebars/releases/tag/v6.0.0
Thanks!
notNeededPackages.json.