[@atom/watcher] Add type definitions#56580
[@atom/watcher] Add type definitions#56580typescript-bot merged 5 commits intoDefinitelyTyped:masterfrom
Conversation
|
@jnv Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 56580,
"author": "jnv",
"headCommitOid": "068709ad4efcf6734c8d9453b2d13775bf179fc6",
"lastPushDate": "2021-10-20T08:25:05.000Z",
"lastActivityDate": "2021-10-20T20:51:10.000Z",
"mergeOfferDate": "2021-10-20T15:48:39.000Z",
"mergeRequestDate": "2021-10-20T20:51:10.000Z",
"mergeRequestUser": "jnv",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "atom__watcher",
"kind": "add",
"files": [
{
"path": "types/atom__watcher/atom__watcher-tests.ts",
"kind": "test"
},
{
"path": "types/atom__watcher/index.d.ts",
"kind": "definition"
},
{
"path": "types/atom__watcher/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/atom__watcher/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"LoganDark",
"jnv"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "sandersn",
"date": "2021-10-20T15:48:01.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 945170428,
"ciResult": "pass"
} |
|
🔔 @jnv — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
Co-authored-by: LoganDark <logandarklock@gmail.com>
|
I think you misspelled package.json |
|
@jnv The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
Definitely misspelled package.json |
|
@jnv The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
🤦 Thanks @LoganDark! |
|
@jnv The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
@jnv The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
For @atom/watcher types, refs: DefinitelyTyped/DefinitelyTyped#56580
|
@jnv One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
|
@sandersn Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
sandersn
left a comment
There was a problem hiding this comment.
@jnv, thanks for adapting @LoganDark's types. It's a big pile of work just to set up a scoped package on DT and get it past the bot.
|
@jnv: Everything looks good here. I am ready to merge this PR (at 068709a) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
|
Ready to merge |
Based upon types provided by @LoganDark in #56006. I have added tests for type definitions and changed the comments to be JSDoc. The type depends on Disposable from
@types/event-kitpackage.Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tslint.jsonshould contain{ "extends": "dtslint/dt.json" }, and no additional rules.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.