@Semigradsky Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• node — on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• 🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 55061,
  "author": "Semigradsky",
  "headCommitOid": "8ce5a3e2159f7f6b9483b269345cd134773a2b59",
  "lastPushDate": "2021-08-10T18:09:23.000Z",
  "lastActivityDate": "2021-08-11T21:40:40.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/test/globals.ts",
          "kind": "test"
        },
        {
          "path": "types/node/ts3.6/base.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Microsoft",
        "DefinitelyTyped",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "KSXGitHub",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "n-e",
        "galkin",
        "parambirs",
        "eps1lon",
        "SimonSchick",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "nguymin4",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "Ryan-Willpower",
        "peterblazejewicz",
        "addaleax",
        "JasonHK",
        "victorperin",
        "ZYSzys",
        "NodeJS",
        "LinusU"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "changereq",
      "reviewer": "amcasey",
      "date": "2021-08-10T21:35:14.000Z"
    }
  ],
  "mainBotCommentID": 896206568,
  "ciResult": "pass"
}

🔔 @microsoft @DefinitelyTyped @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @KSXGitHub @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @nguymin4 @yoursunny @qwelias @ExE-Boss @Ryan-Willpower @peterblazejewicz @addaleax @JasonHK @victorperin @ZYSzys @nodejs @LinusU — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

I'm not sure we can add a dependency like this to @types/node.
I added partial support for this in #55057 (only strings, array, Uint8Array), we should probably augment the node typings instead?

@Semigradsky One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

@SimonSchick so will you add full support TypedArray#at to your PR? In this case this PR can be closed.
I just thought that adding esnext typings to separate package can improve readability and make changing Node.js typings slightly easy.

I wonder why TypedArray#at should be in DefinitelyTyped?
It's part of the JavaScript language, which is usually added to TypeScript itself as a target.

@yoursunny TypedArray#at as Array#at or String#at will be added to lib.d.ts in some day (microsoft/TypeScript#40695). But what about users which can't use the last TypeScript for any reason?

@yoursunny DT needs to still support TS 3.6 (soon 3.7), we sadly can't always rely on bleeding edge libs be available.

Users who need TypedArray#at on older TS can manually import @types/proposal-relative-indexing-method.
There's no need to include it in @types/node.

@yoursunny this seems pretty inconvenient to users, how do we explain to them that, in order to use modern JS features on an older TS version, they must to install some 'proposal-' package?

I think for convenience and simplicities sake the typings should be shipped in node.

how do we explain to them that, in order to use modern JS features on an older TS version, they must to install some 'proposal-' package?

The recommended method shall be setting an appropriate target, using a TypeScript version that supports said target.
Installing proposal- package is merely a workaround.

Landed in node via #55057