node: v15 #52357
node: v15 #52357
Conversation
|
@SimonSchick Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 52357,
"author": "SimonSchick",
"headCommitOid": "86a67aec2146518a96df8eae08ddaf74a23fb46f",
"lastPushDate": "2021-04-24T02:35:20.000Z",
"lastActivityDate": "2021-04-26T19:07:21.000Z",
"maintainerBlessed": false,
"mergeOfferDate": "2021-04-26T11:17:57.000Z",
"mergeRequestDate": "2021-04-26T19:07:21.000Z",
"mergeRequestUser": "victorperin",
"hasMergeConflict": false,
"isFirstContribution": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/assert/strict.d.ts",
"kind": "definition"
},
{
"path": "types/node/crypto.d.ts",
"kind": "definition"
},
{
"path": "types/node/dns.d.ts",
"kind": "definition"
},
{
"path": "types/node/dns/promises.d.ts",
"kind": "definition"
},
{
"path": "types/node/events.d.ts",
"kind": "definition"
},
{
"path": "types/node/fs.d.ts",
"kind": "definition"
},
{
"path": "types/node/globals.d.ts",
"kind": "definition"
},
{
"path": "types/node/http2.d.ts",
"kind": "definition"
},
{
"path": "types/node/index.d.ts",
"kind": "definition"
},
{
"path": "types/node/net.d.ts",
"kind": "definition"
},
{
"path": "types/node/scripts/generate-inspector/README.md",
"kind": "markdown"
},
{
"path": "types/node/scripts/generate-inspector/index.ts",
"kind": "test"
},
{
"path": "types/node/stream.d.ts",
"kind": "definition"
},
{
"path": "types/node/stream/promises.d.ts",
"kind": "definition"
},
{
"path": "types/node/test/crypto.ts",
"kind": "test"
},
{
"path": "types/node/test/events.ts",
"kind": "test"
},
{
"path": "types/node/test/net.ts",
"kind": "test"
},
{
"path": "types/node/test/stream.ts",
"kind": "test"
},
{
"path": "types/node/test/timers.ts",
"kind": "test"
},
{
"path": "types/node/test/timers_promises.ts",
"kind": "test"
},
{
"path": "types/node/timers.d.ts",
"kind": "definition"
},
{
"path": "types/node/timers/promises.d.ts",
"kind": "definition"
},
{
"path": "types/node/ts3.6/base.d.ts",
"kind": "definition"
},
{
"path": "types/node/ts3.6/node-tests.ts",
"kind": "test"
},
{
"path": "types/node/v14/assert.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/async_hooks.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/base.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/buffer.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/child_process.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/cluster.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/console.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/constants.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/crypto.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/dgram.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/dns.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/domain.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/events.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/fs.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/fs/promises.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/globals.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/globals.global.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/http.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/http2.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/https.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/index.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/inspector.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/module.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/net.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/node-tests.ts",
"kind": "test"
},
{
"path": "types/node/v14/os.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/node/v14/path.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/perf_hooks.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/process.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/punycode.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/querystring.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/readline.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/repl.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/stream.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/string_decoder.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/test/assert.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/async_hooks.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/buffer.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/child_process.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/cluster.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/constants.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/crypto.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/dgram.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/dns.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/events.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/fs.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/global.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/globals.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/http.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/http2.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/module.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/net.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/os.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/path.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/perf_hooks.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/process.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/querystring.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/readline.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/repl.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/stream.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/string_decoder.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/tls.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/tty.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/url.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/util.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/v8.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/vm.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/wasi.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/worker_threads.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/zlib.ts",
"kind": "test"
},
{
"path": "types/node/v14/timers.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/tls.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/trace_events.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/ts3.6/assert.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/ts3.6/base.d.ts",
"kind": "definition"
}
],
"owners": [
"Microsoft",
"DefinitelyTyped",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"brunoscheufler",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"KSXGitHub",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"n-e",
"galkin",
"parambirs",
"eps1lon",
"SimonSchick",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"nguymin4",
"yoursunny",
"qwelias",
"ExE-Boss",
"Ryan-Willpower",
"peterblazejewicz",
"addaleax",
"JasonHK",
"victorperin",
"ZYSzys"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "victorperin",
"date": "2021-04-26T19:02:07.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "ZYSzys",
"date": "2021-04-26T11:32:15.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "orta",
"date": "2021-04-26T11:17:21.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "Mesteery",
"date": "2021-04-24T14:16:44.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2021-04-24T12:21:17.000Z",
"isMaintainer": false
},
{
"type": "stale",
"reviewer": "fluggo",
"date": "2021-04-16T16:04:58.000Z",
"abbrOid": "717af95"
},
{
"type": "stale",
"reviewer": "rbuckton",
"date": "2021-04-15T17:50:57.000Z",
"abbrOid": "b0882f3"
}
],
"ciResult": "pass"
} |
|
🔔 @microsoft @DefinitelyTyped @jkomyno @alvis @r3nya @btoueg @BrunoScheufler @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @KSXGitHub @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @nguymin4 @yoursunny @qwelias @ExE-Boss @Ryan-Willpower @peterblazejewicz @addaleax @JasonHK @victorperin @ZYSzys — please review this PR in the next few days. Be sure to explicitly select |
|
@SimonSchick The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
|
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? node/v15.0These typings are for a version of node that doesn’t yet exist on master, so I’ve compared them with v14.14. Comparison details for node/15.0 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. node/v15.0These typings are for a version of node that doesn’t yet exist on master, so I’ve compared them with v14.14. Comparison details for node/15.0 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
|
I've run tests locally on your PR, all passed, thx! |
|
@SimonSchick One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
|
@rbuckton Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
I think we're good now. |
|
@rbuckton I cannot get github to mark your request as resolved for some reason. |
|
@Mesteery, @victorperin, @peterblazejewicz, @fluggo, @rbuckton Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
@Mesteery, @victorperin, @fluggo, @rbuckton Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
I wonder... Now that 16 is already out, is it really worth start maintaining types for 15? At this point in time, I suggest going to 16 directly, saving everyone some of the extra work when PRing to types/node. |
|
@AviVahl the current diff between latest v14 and v16 is too great to do in a single PR, this is an effort to at least get some progress. |
|
And it's awesome, seriously. I've been waiting for the newer types myself for quiet a while and am excited to see this progress. All I'm suggesting is directing the current PR, as-is, to target 16 instead of 15. This would save the community from having to maintain v15 in addition to v16, v14, and v12. I understand there are additional changes that can be done in a future PRs to actually represent everything in 16.0.0, but this can serve as a great start. |
|
I don't think this is a good idea as this would set the expectation that this includes all features up to v16 and makes it difficult to reason which versions features are implemented and which are not. Ideally we would pick up the pace and catch up to node, probably doing 2-3 minor version updates per PR. |
|
I'm already building a v16 version. When this branch get merged, I can cherry pick my changes to a new PR. |
|
@rbuckton can we move forward, I want to move forward with followup pull requests. |
orta
left a comment
There was a problem hiding this comment.
Cool, I'm OK with moving forwards
|
Ready to merge |
|
As I mentioned, I'm working on |
|
@victorperin my intermediate goal is to get to15.3, 15.6, 15.9, 15.12 and finally 15.14 |
|
I just published |
|
I just published |
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
Contains changes from #48981 (minus quic, webcrypto). Thanks @Semigradsky
This brings up the typings up-to-date with v15.0.0, no guarantees are made beyond this version due to the large amount of updates node has received since then (this is left for later PRs).
Some caveats:
node:aliases not working correctly (TS limitation it seems)