@susiwen8 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• react-reconciler on npm, on unpkg

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 51733,
  "author": "susiwen8",
  "headCommitOid": "830fa83f55ea93298945833926447e33b19d532e",
  "lastPushDate": "2021-03-15T14:56:21.000Z",
  "lastActivityDate": "2021-03-15T14:56:21.000Z",
  "maintainerBlessed": false,
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "react-reconciler",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-reconciler/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Methuselah96",
        "zhanghaocong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "stale",
      "reviewer": "Methuselah96",
      "date": "2021-03-15T14:20:16.000Z",
      "abbrOid": "d4fd295"
    }
  ],
  "ciResult": "pass"
}

🔔 @Methuselah96 @zhanghaocong — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@susiwen8 The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

These typings are for a version of react-reconciler that doesn’t yet exist on master, so I’ve compared them with v0.26.

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@Methuselah96 @zhanghaocong Hi, could you review it?

@susiwen8 One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

@Methuselah96 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

I just published @types/react-reconciler@0.26.1 to npm.