[react-native] Add PlatformConstants#51146
[react-native] Add PlatformConstants#51146typescript-bot merged 3 commits intoDefinitelyTyped:masterfrom jgonet:rn/platform-constants
Conversation
|
@jakub-gonet Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 51146,
"author": "jakub-gonet",
"headCommitOid": "f9844f0a49bd45b2338374630b07acb6f2b9fb86",
"lastPushDate": "2021-02-12T21:41:21.000Z",
"lastActivityDate": "2021-02-13T08:26:44.000Z",
"maintainerBlessed": false,
"mergeOfferDate": "2021-02-13T04:11:37.000Z",
"mergeRequestDate": "2021-02-13T08:26:44.000Z",
"mergeRequestUser": "jakub-gonet",
"hasMergeConflict": false,
"isFirstContribution": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "react-native",
"kind": "edit",
"files": [
{
"path": "types/react-native/index.d.ts",
"kind": "definition"
},
{
"path": "types/react-native/test/index.tsx",
"kind": "test"
}
],
"owners": [
"alloy",
"huhuanming",
"iRoachie",
"timwangdev",
"kamal",
"alexdunne",
"swissmanu",
"bm-software",
"a-tarasyuk",
"mvdam",
"esemesek",
"mrnickel",
"souvik-ghosh",
"nossbigg",
"saranshkataria",
"tykus160",
"jakebloom",
"ceyhun",
"mcmar",
"theohdv",
"TheSavior",
"romain-faust",
"bebebebebe",
"Naturalclar",
"chinesedfan",
"vtolochk",
"SychevSP",
"RageBill",
"sasurau4",
"256hz",
"doumart",
"drmas",
"akrger",
"jeremybarbet",
"ca057",
"ds300",
"natsathorn",
"connectdotz",
"TheWirv",
"alexeymolchan",
"alexbrazier",
"kuasha420"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "rbuckton",
"date": "2021-02-13T04:11:01.000Z",
"isMaintainer": true
},
{
"type": "stale",
"reviewer": "ca057",
"date": "2021-02-09T18:17:06.000Z",
"abbrOid": "2cc4e05"
}
],
"ciResult": "pass"
} |
|
🔔 @alloy @huhuanming @iRoachie @timwangdev @kamal @alexdunne @swissmanu @bm-software @a-tarasyuk @mvdam @Esemesek @mrnickel @souvik-ghosh @nossbigg @saranshkataria @tykus160 @jakebloom @ceyhun @mcmar @theohdv @TheSavior @romain-faust @bebebebebe @Naturalclar @chinesedfan @vtolochk @SychevSP @RageBill @sasurau4 @256hz @doumart @drmas @akrger @jeremybarbet @ca057 @ds300 @natsathorn @connectdotz @TheWirv @alexeymolchan @alexbrazier @kuasha420 — please review this PR in the next few days. Be sure to explicitly select |
|
@jakub-gonet The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
|
Not sure why CI is failing with this error: We have recently rewritten react-native-gesture-handler to TS and we use some types from RN. Should I update the config of RN types to enable interop with ES modules or we have some config problem on RNGH side? |
|
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
Co-authored-by: Christian Ost <hallo@christianost.de>
|
@jakub-gonet The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Looks like you might importing React like Either switch to the latter form or enable the |
That's the case, thanks. However, we have |
|
@ca057 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
I released RNGH 1.10.1 with updated React imports and pushed an empty line here. CI should pass now. |
|
@jakub-gonet Everything looks good here. Great job! I am ready to merge this PR (at f9844f0) on your behalf. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@alloy, @huhuanming, @iRoachie, @timwangdev, @kamal, @alexdunne, @swissmanu, @bm-software, @a-tarasyuk, @mvdam, @Esemesek, @mrnickel, @souvik-ghosh, @nossbigg, @saranshkataria, @tykus160, @jakebloom, @ceyhun, @mcmar, @theohdv, @TheSavior, @romain-faust, @bebebebebe, @Naturalclar, @chinesedfan, @vtolochk, @SychevSP, @RageBill, @sasurau4, @256hz, @doumart, @drmas, @akrger, @jeremybarbet, @ca057, @ds300, @natsathorn, @connectdotz, @TheWirv, @alexeymolchan, @alexbrazier, @kuasha420: you can do this too.) |
|
Ready to merge |
|
I just published |
… by @jakub-gonet * Add PlatformConstants * Use string union in uiMode types Co-authored-by: Christian Ost <hallo@christianost.de> * Remove empty line so CI can run Co-authored-by: Christian Ost <hallo@christianost.de>
… by @jakub-gonet * Add PlatformConstants * Use string union in uiMode types Co-authored-by: Christian Ost <hallo@christianost.de> * Remove empty line so CI can run Co-authored-by: Christian Ost <hallo@christianost.de>
Description
The platform was lacking
constantsobject so this PR adds them.Checklist
npm test react-native. – fails with../react/index.d.ts(38,22): error TS2307: Cannot find module 'csstype' or its corresponding type declarations.If changing an existing definition: