@do7be Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• shopify-buy on npm, on unpkg
  • owner-approval: @straiforos

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 50112,
  "author": "do7be",
  "headCommitOid": "768d3e232544967bd29fd4ebb2e8eb0a0e5de109",
  "lastPushDate": "2020-12-14T07:28:59.000Z",
  "lastActivityDate": "2021-01-05T08:06:39.000Z",
  "maintainerBlessed": false,
  "mergeOfferDate": "2021-01-04T22:08:02.000Z",
  "mergeRequestDate": "2021-01-05T08:06:39.000Z",
  "mergeRequestUser": "do7be",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "shopify-buy",
      "kind": "edit",
      "files": [
        {
          "path": "types/shopify-buy/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/shopify-buy/shopify-buy-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "openminder",
        "straiforos",
        "totemika",
        "kilinkis",
        "chrisworman-pela",
        "MaciekBaron"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "straiforos",
      "date": "2020-12-28T22:31:15.000Z",
      "isMaintainer": false
    }
  ],
  "ciResult": "pass"
}

🔔 @openminder @straiforos @totemika @kilinkis @chrisworman-pela @MaciekBaron — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

shopify-buy (unpkg)

was missing the following properties:

1. The declaration doesn't match the JavaScript module 'shopify-buy'. Reason:
   The JavaScript module can be called or constructed, but the declaration module cannot.

Generated by 🚫 dangerJS against 768d3e2

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

Re-ping @openminder, @straiforos, @totemika, @kilinkis, @chrisworman-pela, @MaciekBaron:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@do7be Everything looks good here. Great job! I am ready to merge this PR (at 768d3e2) on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@openminder, @straiforos, @totemika, @kilinkis, @chrisworman-pela, @MaciekBaron: you can do this too.)

Ready to merge

I just published @types/shopify-buy@2.10.4 to npm.